Last modified: 2010-05-15 15:56:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 5661 - Recent changes RSS feed broken in Windows
Recent changes RSS feed broken in Windows
Status: RESOLVED WORKSFORME
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.6.x
PC Windows XP
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-04-19 23:14 UTC by Rupert Millard
Modified: 2010-05-15 15:56 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Rupert Millard 2006-04-19 23:14:54 UTC
This is on PHP version 5.0.5 (apache2handler) & MySQL: 5.0.20-nt 
The recent changes RSS feed is terminated prematurely with the following PHP
warnings:

RSS feed Warning: gmmktime() [function.gmmktime]: Windows does not support
negative values for this function in
C:\Fat32\wwwroot\mediawiki-1.6.3\includes\GlobalFunctions.php on line 1255

Warning: gmdate() [function.gmdate]: Windows does not support dates prior to
midnight (00:00:00), January 1, 1970 in
C:\Fat32\wwwroot\mediawiki-1.6.3\includes\GlobalFunctions.php on line 1286

I have traced this to line 410 of BagOStuff.php, which needs to be changed from:
     return $dbw->timestamp('9999-12-31 12:59:59');
to:
     return $dbw->timestamp('2037-12-31 12:59:59');

I think this is the fault of PHP rather than Windows, but I just thought it
might be helpful to others to have it fixed. Hope this is OK. (My first bugfix!)
Comment 1 Rupert Millard 2006-04-19 23:16:14 UTC
> I think this is the fault of PHP rather than Windows, but I just thought it
> might be helpful to others to have it fixed. Hope this is OK. (My first bugfix!)

I meant to say, "I think this is the fault of PHP on Windows, rather than MediaWiki"
Comment 2 Antoine "hashar" Musso (WMF) 2006-04-30 22:44:10 UTC
Upgrade to PHP 5.1.0:

Quoting: http://www.php.net/manual/en/function.mktime.php

Before PHP 5.1.0, negative timestamps were not supported under any known version
of Windows and some other systems as well. Therefore the range of valid years
was limited to 1970 through 2038. 
Comment 3 Rupert Millard 2006-04-30 22:51:52 UTC
Yes, I'm well aware that it works on that version, but why resist the fix for an
older version, particularly after I have already taken the trouble to do it, so
nobody else has to.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links