Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T7646, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 5646 - XmlFunctions.wfElement() incorrectly checks $contents for emptiness (with Fix)

Summary:	XmlFunctions.wfElement() incorrectly checks $contents for emptiness (with Fix)

Status: RESOLVED FIXED Product: MediaWiki Classification: Unclassified Component: General/Unknown (Other open bugs) Version: 1.7.x Hardware: All All Importance: Normal normal (vote) Target Milestone: --- Assigned To: Nobody - You can work on this! URL: Whiteboard: Keywords: Depends on: Blocks:   Show dependency tree / graph		Reported: 2006-04-18 20:29 UTC by Yuri Astrakhan Modified: 2006-04-18 20:58 UTC (History) CC List: 0 users See Also: Web browser: --- Mobile Platform: --- Assignee Huggle Beta Tester: ---

Attachments Add an attachment (proposed patch, testcase, etc.)

Description Yuri Astrakhan 2006-04-18 20:29:07 UTC In the function wfElement( $element, $attribs = null, $contents = '') in includes/XmlFunctions.php incorrectly checks if the content is empty: if( $contents == '' ) { It should be ===, otherwise when $content is integer 0, that line gives a false positive.