Last modified: 2006-07-04 16:45:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 5621 - A block link is shown in the new users log
A block link is shown in the new users log
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Newuserlog (Other open bugs)
unspecified
All All
: Normal trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-04-17 14:45 UTC by Rotem Liss
Modified: 2006-07-04 16:45 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch (1.02 KB, patch)
2006-04-17 14:46 UTC, Rotem Liss
Details
Patch v2 (1.42 KB, patch)
2006-04-17 15:37 UTC, Rotem Liss
Details

Description Rotem Liss 2006-04-17 14:45:24 UTC
A block link is shown in the comment of the log also for non-sysops. There is no
way to differ the comments for sysops and for non-sysops, so I suggest to remove
this link. (All these links are actually redundant for the links in the Recent
Changes are shown, and when those links will be added also to Special:Log, we
will be able to remove them from the log entry, and leave only "New user".)

A patch is coming soon.
Comment 1 Rotem Liss 2006-04-17 14:46:14 UTC
Created attachment 1558 [details]
Patch

The patch just removes the block link.
Comment 2 Rotem Liss 2006-04-17 14:54:14 UTC
Mmm, the code I've used is old. Please wait a minute.
Comment 3 Rotem Liss 2006-04-17 15:37:42 UTC
Created attachment 1559 [details]
Patch v2

Now the patch is updated. This patch removes "Block", and in addition, removes
"newuserloglog" (it was said "for compatibility", but the text created from
this message is stored in the database, and we don't use it anymore). Also, it
fixes the following comments:
// Compatibility entries.
// Old code stored Special:Userlogin as the target, not very helpful.
to:
// Old log entries (real content was in field "log_comment" in the database)
because the comment about the fact "Special:Userlogin" was stored may be
interesting, but how does it help for those who want to understand the code?
Comment 4 Brion Vibber 2006-04-17 21:14:53 UTC
Will not accept this patch.

Would perhaps accept some fixes to the log system allowing it to 
display alternate forms for the user, but it's not really 
necessary.
Comment 5 Rotem Liss 2006-04-17 21:36:20 UTC
(In reply to comment #4)
> Will not accept this patch.

Why not? We have the same links in Special:Recentchanges, if we want to block
him immediantly. I also will suggest to add such links also to Special:Log, so
we won't need all of these links anymore.
Comment 6 Rob Church 2006-07-04 16:45:41 UTC
Such links are now present in log pages.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links