Last modified: 2014-02-12 23:52:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58153, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56153 - MFResourceLoaderModule doesn't always obey debug mode
MFResourceLoaderModule doesn't always obey debug mode
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-25 10:15 UTC by Liangent
Modified: 2014-02-12 23:52 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Liangent 2013-10-25 10:15:09 UTC
Exception thrown by mobile.stable.common: Cannot call method 'add' of undefined load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.t…Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20131025T025614Z:10260
TypeError {} load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.t…Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20131025T025614Z:10266
log load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.t…Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20131025T025614Z:10266
runScript load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.t…Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20131025T025614Z:10486
execute load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.t…Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20131025T025614Z:10589
handlePending load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.t…Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20131025T025614Z:10336
markModuleReady load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.t…Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20131025T025614Z:10460
nestedAddScript load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.t…Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20131025T025614Z:10467
runScript load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.t…Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20131025T025614Z:10477
execute load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.t…Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20131025T025614Z:10589
mw.loader.implement load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.t…Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20131025T025614Z:10971
(anonymous function) load.php?debug=true&lang=en&modules=ext.centralNotice.bannerController%7Cex…ctor.js%7Cwikibase.client.init&skin=vector&version=20131025T101316Z&*:1300
Comment 1 Bingle 2013-10-25 10:16:17 UTC
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1333
Comment 2 Jon 2013-10-28 19:58:54 UTC
This is actually not specific to the nearby page and effects mobile pages in debug mode.
Comment 3 Krinkle 2013-10-28 20:43:16 UTC
Looks like 'target' is missing from ResourceLoaderContext and makeLoaderURL. This probably means that any requests embedded in the HTML are broken (not found) as well if they are restricted by target.
Comment 4 Jon 2013-10-29 01:50:44 UTC
Nearby code sets targets as desktop AND mobile so I don't think this is the case.

Can also be replicated on mobile:
https://en.m.wikipedia.org/wiki/Special:Nearby?debug=true

It seems that the load order is not honoured. You'll see mw.template.add("articleList appears before  //bits.wikimedia.org/static-1.22wmf22/extensions/MobileFrontend/javascripts/common/templates.js
is injected - and one is plain JavaScript and one is a file path in this url [1]



[1] https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=true&lang=en&modules=ext.centralNotice.bannerController.mobile%2Cmobiledevice%7Cjquery.client%2Ccookie%2Cjson%2CmwExtension%7Cmediawiki.cldr%2CjqueryMsg%2Clanguage%2Cnotify%2Cutil%7Cmediawiki.language.data%2Cinit%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.startup%7Cmobile.head%2CloggingSchemas%2Cnearby%2Cstartup%2Ctemplates%7Cmobile.nearby.scripts%2Cstyles%7Cmobile.stable.common%7Cmobile.toast.styles&skin=vector&version=20131029T013743Z&*
Comment 5 Bingle 2013-10-29 01:52:24 UTC
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1340
Comment 6 Gerrit Notification Bot 2013-11-07 18:32:42 UTC
Change 94171 had a related patch set uploaded by Jdlrobson:
Make debug=true work again

https://gerrit.wikimedia.org/r/94171
Comment 7 Gerrit Notification Bot 2013-11-07 20:09:47 UTC
Change 94171 merged by jenkins-bot:
Make debug=true work again

https://gerrit.wikimedia.org/r/94171

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links