Last modified: 2013-10-31 13:18:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T58117, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 56117 - [RefToolbarLegacy] js error and wikitext error when editor for create page fails to appear in IE10 (at least): 'unable to get property 'appendChild' of undefined or null reference'
[RefToolbarLegacy] js error and wikitext error when editor for create page fa...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.22.0
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: browser-test-bug
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-24 19:32 UTC by Chris McMahon
Modified: 2013-10-31 13:18 UTC (History)
2 users (show)

See Also:
Web browser: Internet Explorer
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
js error IE10 no editor (106.07 KB, image/png)
2013-10-24 19:32 UTC, Chris McMahon
Details
proveit should not appear (196.66 KB, image/png)
2013-10-24 19:32 UTC, Chris McMahon
Details

Description Chris McMahon 2013-10-24 19:32:05 UTC
Created attachment 13565 [details]
js error IE10 no editor

Edit a URL that does not exist e.g. 

http://en.wikipedia.beta.wmflabs.org/wiki/0.721023e4802348

Click Create source

The wikitext editor sometimes not appear at all.

When this happens the error is 'unable to get property 'appendChild' of undefined or null reference'

See screen shot. 

Also, styling from the ProveIt gadget sometimes appears also, even though ProveIt is unselected in Preferences for this user. 

See screen shot.
Comment 1 Chris McMahon 2013-10-24 19:32:53 UTC
Created attachment 13566 [details]
proveit should not appear
Comment 2 Chris McMahon 2013-10-24 19:35:06 UTC
line causing js error is 

 document.getElementById('citeselect').appendChild( reftoolformarea );
Comment 3 Umherirrender 2013-10-25 13:43:17 UTC
That is a local script:
http://en.wikipedia.beta.wmflabs.org/wiki/MediaWiki:RefToolbarLegacy.js

Nothing for bugzilla
Comment 4 Matthew Flaschen 2013-10-26 00:21:23 UTC
As noted by  Umherirrender, that line is not part of ProveIt.  It's part of RefToolbarLegacy, loaded via:

MediaWiki:Common.js -> MediaWiki:Common.js/edit.js -> MediaWiki:RefToolbarLegacy.js

Relevant to your testing, MediaWiki:Common.js/edit.js has a hard-coded reference to en.wikipedia.org, which means it's pulling stuff from prod rather than the test environment.  This should be fixed.

RefToolbarLegacy.js is entirely separate from ProveIt (despite having a similar purpose).

It seems very odd that ProveIt would load without being enabled.  I have never had that reported, nor do I know of any mechanism that bug could occur.  If you are sure it's not being enabled somehow, and can reproduce that, you should file a separate bug against ResourceLoader.

It seems you're testing in production mode in your screenshots.  Obviously, it's important to test in production mode.  However, when reporting errors on specific lines, please also retest in debug mode.  That will generally provide useful filenames and line numbers.
Comment 5 Matthew Flaschen 2013-10-31 05:23:04 UTC
(In reply to comment #0)
> Also, styling from the ProveIt gadget sometimes appears also, even though
> ProveIt is unselected in Preferences for this user. 

Chris and I emailed briefly about this, and I think this is this is because of http://en.wikipedia.beta.wmflabs.org/wiki/User:Selenium_user/vector.js .  That file should be blanked or deleted.

Also, that is no longer a supported method of loading ProveIt (I had some out of date docs on this, but they should be right now).

When re-resting the gadget on Beta, it should be set up the same way as on English Wikipedia, with the relevant line of https://en.wikipedia.org/wiki/MediaWiki:Gadgets-definition , plus copying over the complete pages https://en.wikipedia.org/wiki/MediaWiki:Gadget-ProveIt.js and https://en.wikipedia.org/wiki/MediaWiki:Gadget-ProveIt.css .
Comment 6 Matthew Flaschen 2013-10-31 05:24:02 UTC
I mean 're-testing'. :)
Comment 7 Chris McMahon 2013-10-31 13:18:14 UTC
Misconfigured by accident, closing. 

Any related issues to be noted in other reports.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links