Last modified: 2006-04-18 18:07:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 5592 - Set the logs fixed text in Recent Changes as the site language, not the user's one
Set the logs fixed text in Recent Changes as the site language, not the user'...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
unspecified
All All
: Normal minor with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-04-16 08:09 UTC by Rotem Liss
Modified: 2006-04-18 18:07 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch (trunk) (857 bytes, patch)
2006-04-16 13:22 UTC, Rotem Liss
Details
Patch (REL1_6) (857 bytes, patch)
2006-04-16 13:32 UTC, Rotem Liss
Details

Description Rotem Liss 2006-04-16 08:09:40 UTC
I'm not sure how to do that, but we should create the logs' fixed text (for
example, Deletion Log) in Recent Changes as the site language (wfMsgForContent?)
instead of the user's one (wfMsg). Maybe there should be another parameter to
the function creates the text (I don't remember its name).

For example, if I have an English project, and I select the French language in
my preferences and delete a page, the log entry is in the local language for
everyone (for example, English) in [[Special:Log/delete]], but always in French
in [[Special:Recentchanges]]. Maybe we cannot change the entry by setting
language for ourselves in the site (I mean, it will always be in English), but
it should be in the site's language.

I would like to create a patch, maybe that will make the bug report clear.
Comment 1 Brion Vibber 2006-04-16 08:13:53 UTC
Do you mean the log entry or the default comment text?
Comment 2 Rotem Liss 2006-04-16 08:15:41 UTC
(In reply to comment #1)
> Do you mean the log entry or the default comment text?

I mean the log entry – "X deleted Y" in the site's language vs the user's language.
Comment 3 Rotem Liss 2006-04-16 08:17:26 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > Do you mean the log entry or the default comment text?
> 
> I mean the log entry – "X deleted Y" in the site's language vs the user's
language.

Mmm… actually, both of them, when I come to look at the deletion page.
Comment 4 Rotem Liss 2006-04-16 08:18:14 UTC
(In reply to comment #3)
> Mmm… actually, both of them, when I come to look at the deletion page.

However, the default comment text is already well.
Comment 5 lɛʁi לערי ריינהארט 2006-04-16 10:39:19 UTC
Thanks Rotem Liss for planning a patch about this complex topic!

As I understand 'special:Recentchanges' there are different fields that belong
to log events:
- the ones that can and *should* be localised when
'special:Recentchanges?uselang=xx' is used
- the ones that are *fields* in the database associated with that log event and
may differ from log event to log event; some of these fields are automatically
generated "comments"; most of them can not be localized later

There are many reports specifying log events in 'special:Recentchanges':

Bug 5387: Block log items on RecentChanges don't make use of possible translations
Bug 4920: [[Special:Recentchanges]] does not use the content language when
displaying log events (as move)
*note* bug 4920 should be read carefully; maybe wording is not exactly
describing the problem and does not differenciate about what should / could be
localized when 'special:Recentchanges?uselang=xx' is used and what not

Bug 3615: Blocks of code not handling magic character conversions in Esperanto
correcty (as reason for page deletion etc.)
That one is mentioning specialities related to Esperanto magic conversion and
broken links because of missing or multiple "magic conversion"

Good luck! reinhardt [[user:gangleri]]

The correspondend bug about 'special:Log' is:
Bug 2273: Logs should use the content language and should not depend on the
selected user interface
Comment 6 Rotem Liss 2006-04-16 13:22:58 UTC
Created attachment 1544 [details]
Patch (trunk)

The patch changes LogPage:actionText, and differs the status (whether we want
to get this text from Special:Log (this means it should be in the user's
langauge), or we want to get this text from LogPage:addEntry for storing in the
table "recentchanges" and using this in Special:Recentchanges (this means it
should be in the site's default language)) by the parameter $skin (used also to
check whether we have to use links in the log action text or not). If $skin, we
don't get it for content; else, we do.

And one more thing: if there are params in array, we cannot use wfMsg or
wfMsgForContent, and we have to use wfMsgReal. The reason – wfMsg and
wfMsgForContent cannot get an array. So I've deleted the "FIXME" message.

The patch actually causes that if a user uses the language X in a site uses the
language Y, the log messages in Special:Log will be shown for him in language X
(as usual), but his actions documented in Special:Recentchanges as "(Log Name)
Action etc." will be in language Y (now in language X). As for another visitor
uses language Z, he will see the actions of the user uses language X in
Special:Log in language Z, and the actions in Special:Recentchanges in language
Y.

Patch for REL1_6 is coming soon.
Comment 7 Rotem Liss 2006-04-16 13:32:18 UTC
Created attachment 1545 [details]
Patch (REL1_6)

The same.
Comment 8 lɛʁi לערי ריינהארט 2006-04-18 11:41:08 UTC
http://de.wikibooks.org/w/index.php?title=Spezial%3ALog&type=newusers&user=&page=
was reported today at irc://irc.freenode.net/wikimedia by '<John|N>'
Comment 9 Rotem Liss 2006-04-18 11:50:29 UTC
(In reply to comment #8)
> http://de.wikibooks.org/w/index.php?title=Spezial%3ALog&type=newusers&user=&page=
> was reported today at irc://irc.freenode.net/wikimedia by '<John|N>'

The reason for that is not this bug, but the fact they hadn't translated
[[b:de:MediaWiki:newuserlog-create-entry]].

By the way, could someone please check in the patch?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links