Last modified: 2014-04-29 20:43:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57753, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55753 - [OPS] Jenkins: Upgrade jsduck from v4.x to v5.x
[OPS] Jenkins: Upgrade jsduck from v4.x to v5.x
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
wmf-deployment
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: ops
Depends on: 55752
Blocks: 57039
  Show dependency treegraph
 
Reported: 2013-10-15 20:13 UTC by Krinkle
Modified: 2014-04-29 20:43 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2013-10-15 20:13:55 UTC
We're currently on v4.10.4 (bug 53731).

v5.x brings various enhancements and bug fixes, among it a new event system. However since this is a major upgrade, don't poke ops yet because we got some stuff to figure out first.


This is a reminder to do this things (see also blocking bugs).
Comment 1 Antoine "hashar" Musso (WMF) 2013-11-19 10:43:45 UTC
From an IRC discussion with James on IRC:

You need a RT ticket to get the new version packaged. The debian files are in operations/debs/ruby-jsduck.git

Then ping ops till someone is assigned and able to update the package and upload it on apt.wikimedia.org

Then one (ops / me) can manually upgrade the package on the Jenkins CI slaves ( gallium.wikimedia.org / lanthanum.eqiad.wmnet )
Comment 2 James Forrester 2013-11-19 12:20:50 UTC
Request created as RT #6344.
Comment 3 Antoine "hashar" Musso (WMF) 2013-12-02 13:38:31 UTC
Pending ops
Comment 4 James Forrester 2013-12-03 20:07:55 UTC
RT ticket is assigned to Matanya; marking as such here too.
Comment 5 Krinkle 2014-04-19 05:16:44 UTC
Dependencies have been resolved. Projects using jsduck have been migrated to be compatible with JSDuck 5 where needed.

We're now in fact have projects blocked on this upgrade as they are not only compatible with jsduck 5, but incompatible with the (now, quite outdated) jsduck v4.

Please commence upgrade ASAP :)
Comment 6 matanya 2014-04-19 19:12:03 UTC
The blocker on the ops side is ubuntu trusty image for labs. Ryan lane is working on it, and it should be resolved shortly, i hope. Once one can use trusty images in labs it will be quite easy to solve this. Maybe Faidon will want to do this with precise, but i suggest not. Ryan might know the exact status on this matter.
Comment 7 Antoine "hashar" Musso (WMF) 2014-04-19 19:25:46 UTC
Timo, we can probably skip the Debian package entirely and use gem instead of Debian package.

matanya, what is preventing ops from backporting JSDuck to Ubuntu Precise?  I am not going to use Ubuntu Trusty for CI anytime soon.
Comment 8 matanya 2014-04-19 19:36:03 UTC
The jsduck folks changed there internal engine and have new dependencies which aren't met in precise. It is probably doable, but hard.
Comment 9 Antoine "hashar" Musso (WMF) 2014-04-29 07:49:30 UTC
RT #6344 has been closed by Alexandros:

> JSDuck 5.3.4 ended up having as a dependency rkelly-remix (a fork of rkelly
> by the dev(s) of JSDuck). 
> This has also been packaged. 
> Both packages have been tested by Timo and afterwards confirmation I have
> uploaded them both on apt.wikimedia.org

$ apt-cache policy ruby-jsduck 
ruby-jsduck:
  Installed: 4.10.4-1~wmf1
  Candidate: 5.3.4-1wmf1
  Version table:
     5.3.4-1wmf1 0
       1001 http://apt.wikimedia.org/wikimedia/ precise-wikimedia/main amd64 Packages
 *** 4.10.4-1~wmf1 0
        100 /var/lib/dpkg/status

$ apt-cache policy ruby-rkelly-remix
ruby-rkelly-remix:
  Installed: (none)
  Candidate: 0.0.6-1
  Version table:
     0.0.6-1 0
       1001 http://apt.wikimedia.org/wikimedia/ precise-wikimedia/main amd64 Packages


Timo, whenever you are ready to switch to jsduck we can apt-get upgrade gallium to install the new package :)
Comment 10 Krinkle 2014-04-29 17:49:43 UTC
@matanya and @andrewbogott applied the upgrade on gallium.

Kicked off build:
https://integration.wikimedia.org/ci/job/mediawiki-core-jsduck-publish/927/console
> Finished: SUCCESS

https://doc.wikimedia.org/mediawiki-core/master/js/

> Generated by JSDuck 5.3.4.
Comment 11 Antoine "hashar" Musso (WMF) 2014-04-29 20:43:53 UTC
Congratulations Timo \O/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links