Last modified: 2014-05-18 15:38:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57468, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55468 - Update "Create account" / "login" buttons in ConfirmAccount
Update "Create account" / "login" buttons in ConfirmAccount
Status: VERIFIED WONTFIX
Product: MediaWiki extensions
Classification: Unclassified
ConfirmAccount (Other open bugs)
unspecified
All All
: Unprioritized trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
aklapper-moreinfo
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-08 15:52 UTC by paladox2015
Modified: 2014-05-18 15:38 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
this is the first code change (3.11 KB, patch)
2014-05-18 11:52 UTC, paladox2015
Details
2nd patch (2.08 KB, patch)
2014-05-18 11:54 UTC, paladox2015
Details
ingor the 1st patch this is the updated 1st patch (3.62 KB, patch)
2014-05-18 11:58 UTC, paladox2015
Details

Description paladox2015 2013-10-08 15:52:36 UTC
Hi please update login and create account buttons because the layout and look of them was changed in 1.20 when they separated them into create account and then login so please update the looks and the create account could be redirect to special request account. I am running Mediawiki 1.22 Wmf 20. I was told to file a bug here at https://www.mediawiki.org/wiki/Thread:Project:Support_desk/Create_account_/_login_in_extension:confirmaccount
Comment 1 Andre Klapper 2013-10-08 20:26:30 UTC
Please stop setting "blocker" severity for all of your bug reports. The meaning of blocker is defined here: https://www.mediawiki.org/wiki/Bugzilla/Fields#importance . This is obviously not a blocker at all.

For the bug report itself, please provide a screenshot which icons you refer to.
Comment 2 paladox2015 2013-10-11 19:11:42 UTC
OK
Comment 3 Andre Klapper 2014-04-21 04:43:37 UTC
Unfortunately closing this report as no further information has been provided.

paladox2015: Please feel free to reopen this report if you can provide the information asked for in comment 1 and if this still happens. Thanks!
Comment 4 paladox2015 2014-04-22 16:14:14 UTC
Hi This is a feature request.
Comment 5 Andre Klapper 2014-04-23 05:59:15 UTC
(In reply to paladox2015 from comment #4)
> Hi This is a feature request.

Comment 1 had open requests. Anyway, this ticket is closed now anyway.
Comment 6 paladox2015 2014-05-17 14:05:33 UTC
hi please add the following to this https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FConfirmAccount/8371f282499d2f715a56ed18b6a9fa0b0e8e3e8b/frontend%2FConfirmAccountUI.hooks.php please

the link is for request account and would be next to login 

$wgHooks['PersonalUrls'][] = 'onPersonalUrls';


function onPersonalUrls( array &$personal_urls, Title $title, SkinTemplate $skin  ) {
    // Add a link to Special:RequestAccount if a link exists for login
    if ( isset( $personal_urls['login'] ) || isset( $personal_urls['anonlogin'] ) ) {
            $personal_urls['createaccount'] = array(
                'text' => wfMessage( 'requestaccount' )->text(),
                'href' => SpecialPage::getTitleFor( 'RequestAccount' )->getFullURL()
            );
    }
    return true;
}

and please also change this code in that link it will change the name of link from login/create account to login 


   public static function setRequestLoginLinks( array &$personal_urls, &$title ) {
 

        if ( isset( $personal_urls['anonlogin'] ) ) {
 

            $personal_urls['anonlogin']['text'] = wfMessage( 'login' )->escaped();
 

        } elseif ( isset( $personal_urls['login'] ) ) {
 

            $personal_urls['login']['text'] = wfMessage( 'login' )->escaped();
 

        }
 

        return true;
 

    }
Comment 7 Andre Klapper 2014-05-17 14:45:01 UTC
You are welcome to use Developer access
  https://www.mediawiki.org/wiki/Developer_access
to submit this as a patch (Git branch) directly into Gerrit:
  https://www.mediawiki.org/wiki/Git/Tutorial

Putting your branch in Git makes it easier to review it quickly. If you don't want to set up Git/Gerrit, you can also use https://tools.wmflabs.org/gerrit-patch-uploader/
Comment 8 paladox2015 2014-05-18 11:21:35 UTC
Ok thanks.
Comment 9 paladox2015 2014-05-18 11:50:37 UTC
hi I am trying to use the uploader but I doint know how to use it I have a mediawiki account but it says that it is not a unified diff patch
Comment 10 paladox2015 2014-05-18 11:52:16 UTC
Created attachment 15427 [details]
this is the  first code change
Comment 11 paladox2015 2014-05-18 11:54:08 UTC
Created attachment 15428 [details]
2nd patch

this is the 2nd patch read details for the files located
Comment 12 paladox2015 2014-05-18 11:58:12 UTC
Created attachment 15429 [details]
ingor the 1st patch this is the updated 1st patch
Comment 13 Andre Klapper 2014-05-18 15:38:45 UTC
(In reply to paladox2015 from comment #9)
> hi I am trying to use the uploader but I doint know how to use it I have a
> mediawiki account but it says that it is not a unified diff patch

Could you please use proper punctuation as it makes text way more readable?
See https://en.wikipedia.org/wiki/Punctuation for the general concept.

"man diff" explains how to create a unified patch, and the stuff you uploaded here is not a patch, see https://en.wikipedia.org/wiki/Patch_%28Unix%29
(Discussing this is out of scope for this specific bug report, and this bug report is closed anyway.)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links