Last modified: 2006-04-09 16:02:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 5515 - "rcshowhidepatr" is shown even if the user is not authorized to patrol
"rcshowhidepatr" is shown even if the user is not authorized to patrol
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-04-09 15:29 UTC by Rotem Liss
Modified: 2006-04-09 16:02 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Rotem Liss 2006-04-09 15:29:50 UTC
Bug #5409 is fixed, but "rcshowhidepatr" is shown even if the user is not
authorized to patrol. (The exclamation mark and the change in "diff" are not
shown if the user is not authorized.)

These are the cases (when the user is sysop, of course):

Case 1:
* $wgUseRCPatrol = true;
* $wgGroupPermissions["sysop"]["patrol"] = true;

Results (normal):
* rcshowhidepatr is shown.
* The exclamation mark and the change in "diff" are shown.

Case 2:
* $wgUseRCPatrol = false;
* $wgGroupPermissions["sysop"]["patrol"] = true;

Results (normal):
* rcshowhidepatr is not shown.
* The exclamation mark and the change in "diff" are not shown.

Case 3:
* $wgUseRCPatrol = true;
* $wgGroupPermissions["sysop"]["patrol"] = false;

Results (not normal):
* rcshowhidepatr is *shown*.
* The exclamation mark and the change in "diff" are not shown.

Case 4:
* $wgUseRCPatrol = false;
* $wgGroupPermissions["sysop"]["patrol"] = false;

Results (normal):
* rcshowhidepatr is not shown.
* The exclamation mark and the change in "diff" are not shown.

The "rcshowhidepatr" is shown whenever $wgUseRCPatrol is true, and the system
doesn't check whether the user has the "patrol" permission or not. The function
"usePatrol()" of the recent changes list does check it.
Comment 1 Rob Church 2006-04-09 15:52:21 UTC
This is intended behaviour.
Comment 2 Rotem Liss 2006-04-09 16:02:46 UTC
So we should also show the exclamation mark even for users without the "patrol"
permission (although we shouldn't change the "diff" link), for they will be able
to know what is patrolled and what is not patrolled.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links