Last modified: 2014-02-07 19:40:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 5491 - Colour-coding of items in page histories
Colour-coding of items in page histories
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
unspecified
All All
: Normal enhancement with 4 votes (vote)
: ---
Assigned To: Johan Uhle
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-04-07 12:43 UTC by Liquid_2003
Modified: 2014-02-07 19:40 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
First Try On Adding This Feature (1.52 KB, patch)
2008-12-01 18:35 UTC, Johan Uhle
Details
Picture on how this looks (115.23 KB, image/png)
2008-12-01 18:37 UTC, Johan Uhle
Details
Second Revision of the Patch with no colors but borders used (1.58 KB, patch)
2008-12-04 17:28 UTC, Johan Uhle
Details
Picture of how it looks with borders (106.51 KB, image/png)
2008-12-04 17:29 UTC, Johan Uhle
Details

Description Liquid_2003 2006-04-07 12:43:15 UTC
In order ton make history reading easier, it will be cool (yep !) to mark
contribs with colors. I'm trying to explain better :/

* in <font color="c080e0"><u>pink</u></font>, IP contributions
* in <font color="red"><u>red</u></font>, sysop contributions (when they clicked
on "revert", "rename" for example)
* in <font color="green"><u>green</u></font> modifications made by user viewing
history (hmm ... I want to say everyone should see his own modifications in a
specific color, like green here).
* and default colors for others modifications.

Is it possible to add a little option in ''preferences'' to diplay or not
colored histories ? Will be usefull for sysop ! And funny :) ...
Comment 1 Johan Uhle 2008-12-01 18:35:57 UTC
Created attachment 5548 [details]
First Try On Adding This Feature
Comment 2 Johan Uhle 2008-12-01 18:37:00 UTC
Created attachment 5549 [details]
Picture on how this looks
Comment 3 Johan Uhle 2008-12-01 18:37:34 UTC
Hi There,
this looks like a nice enhancement to me, improving overview in history view, so I made a patch for this. It changes the backgroundcolor of the line, according to the user who made the revision:

Not logged in User -> White
Some logged in User -> Yellow
Currently logged in User -> Green
Sysop -> Pink

Of course, it uses CSS. Changes have been made to shared.css, so skins can override this. I tested it with various skins and it works fine. Image of the looks attached. Feedback appreciated.
Comment 4 Aaron Schulz 2008-12-01 18:39:56 UTC
Re-opening. WFM is for closing bugs about errors that no one can re-produce/don't seem to exist.
Comment 5 Alex Z. 2008-12-01 20:29:37 UTC
Adding the classes might be a good idea, but I don't think assigning default colors is necessary. I think that should be left up to individual sites or skin designers. Additionally, color combinations with the link+background text could potentially have accessibility issues for visually impaired users, especially things like red text on pink background, blue/green might have the same issue.
Comment 6 Johan Uhle 2008-12-01 21:30:22 UTC
@#5
I orientated the default colors to the default colors in /skins/common/diff.css.
I thought, "If they have default colors their, why shouldn't I use them, too"? Furthermore, can't the skin designers just override my colors with their own if they want to?

I do totally agree with your critisicm about the bad color combination. I may think of a different color combinations, after we have clarified the "default colors"-issue.

Futhermore, there is the question of how to document this color scheme to the user on the history page.
Comment 7 Johan Uhle 2008-12-04 17:28:28 UTC
Created attachment 5559 [details]
Second Revision of the Patch with no colors but borders used

First thing I want to point out, that this patch would be a nice enhancement for the history view, because one would be able to check the involvement of sysops and registered user in changing a site with one glance.

I have thought about the colorblindness-thing a lot more and don some research on the web about this issue and read a lot of stuff. I've done some checking with this tool:  http://www.paciellogroup.com/resources/contrast-analyser.html which implements the Accessibility Guidelines of the WC3 http://www.w3.org/TR/2007/WD-WCAG20-TECHS-20070517/Overview.html

My conclusion is, that there is no good color-scheme to be picked, matching the criteria of having a color in the background, that leaves the foreground text 100 % readable appart from plain white. Not even the "grey" (#F9F9F9) used at the moment in the background of the "Compare Selected Versions" Boxes is 100 % WC3 Contrast Ratio proof (Contrast Ratio against Red is 3,8:1 but should be 5:1).

So i thought of a different solution using borders.
1. IP-User have just plain white background
2. Logged-In-Users have the same "grey" background as already used
3. SysOPs have "grey" background and a 1px solid border
4. The current logged-in user has a grey background and a 2px border (i want to see what i have done with this page)
Comment 8 Johan Uhle 2008-12-04 17:29:53 UTC
Created attachment 5560 [details]
Picture of how it looks with borders
Comment 9 Johan Uhle 2009-01-05 15:51:13 UTC
The color solution and the border solution do not work as they should. A solution with dedicated icons runs into the problem that skin developers would have to do new icons for this. Could any skin developer please comment on this? If not, I guess it would be better to close this bug. 
Comment 10 Liquid_2003 2009-01-06 11:22:47 UTC
(In reply to comment #9)
> The color solution and the border solution do not work as they should. A
> solution with dedicated icons runs into the problem that skin developers would
> have to do new icons for this. Could any skin developer please comment on this?
> If not, I guess it would be better to close this bug. 
> 

There is a feature created by some wikipedians that I've added to my Monobook here :
http://fr.wikipedia.org/wiki/Utilisateur:Liquid_2003/monobook.css
A few days ago, there was icons too, from the Crystal Clear pack.
Comment 11 John Du Hart 2011-09-01 03:15:32 UTC
Comment on attachment 5559 [details]
Second Revision of the Patch with no colors but borders used

Thanks for submitting a patch to MediaWiki. Unfortunately I'm going to have to mark them as obsolete because they no longer merge into our current code. However I would like to touch on two things about the patch:

1. MediaWiki has a strict guideline on how code should be formatted. Mainly, single line if statements are highly discouraged as they aren't very readable.
http://www.mediawiki.org/wiki/Manual:Coding_conventions

2. The following code is worrying

 User::newFromId($revUserId)->getGroups()

Although it may not look like much it can possibly add a large amount of Queries to the page. You're loading up a user object which requires a separate database query for each revision. Ouch. If you were to re-implement this today you should look at creating a JOIN in the query to get user groups


Thank you very much though for submitting this patch, any bit helps. =)
Comment 12 Dan Garry 2014-02-07 19:40:22 UTC
Changing to RESOLVED WONTFIX as this is issue is both stale and also sounds like all it would do is turn the history page into an assault on the senses.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links