Last modified: 2014-02-13 07:56:46 UTC
It doesn't look like SpecialOpenIDLogin.body.php is doing the same checks that MediaWiki core is doing on account creation. I'm not sure if vandals could abuse this, but it would be good to check. Specific checks that need to happen (apologies if I've missed these somewhere else): * Username needs to valid against the 'creatable' checks, so some thing like $u = User::newFromName( $name, 'creatable' ); if ( !is_object( $u ) ) { return null; * The AbortNewAccount hook should be run * IP throttle needs to be checked * Make sure the email passes Sanitizer::validateEmail() Thanks!
Thanks for reporting and giving starting points. I will try to fix this as soon as possible.
Change 95076 had a related patch set (by Wikinaut) published: Bug 54677: Do account creation checks when creating users https://gerrit.wikimedia.org/r/95076
Change 95076 merged by Wikinaut: Bug 54677: (partial) check email addresses Sanitizer::validateEmail() https://gerrit.wikimedia.org/r/95076