Last modified: 2014-02-13 07:56:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56677, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54677 - Do account creation checks when creating users
Do account creation checks when creating users
Status: ASSIGNED
Product: MediaWiki extensions
Classification: Unclassified
OpenID (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: T. Gries
:
Depends on:
Blocks: 9604
  Show dependency treegraph
 
Reported: 2013-09-27 03:05 UTC by Chris Steipp
Modified: 2014-02-13 07:56 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chris Steipp 2013-09-27 03:05:19 UTC
It doesn't look like SpecialOpenIDLogin.body.php is doing the same checks that MediaWiki core is doing on account creation. I'm not sure if vandals could abuse this, but it would be good to check.

Specific checks that need to happen (apologies if I've missed these somewhere else):

* Username needs to valid against the 'creatable' checks, so some thing like
	$u = User::newFromName( $name, 'creatable' );
	if ( !is_object( $u ) ) {
		return null;

* The AbortNewAccount hook should be run

* IP throttle needs to be checked

* Make sure the email passes Sanitizer::validateEmail()

Thanks!
Comment 1 T. Gries 2013-09-27 06:33:16 UTC
Thanks for reporting and giving starting points. I will try to fix this as soon as possible.
Comment 2 Gerrit Notification Bot 2013-11-12 23:59:23 UTC
Change 95076 had a related patch set (by Wikinaut) published:
Bug 54677: Do account creation checks when creating users

https://gerrit.wikimedia.org/r/95076
Comment 3 Gerrit Notification Bot 2013-11-15 20:37:59 UTC
Change 95076 merged by Wikinaut:
Bug 54677: (partial) check email addresses Sanitizer::validateEmail()

https://gerrit.wikimedia.org/r/95076

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links