Last modified: 2014-11-18 18:07:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 5445 - Remove autoblocks when a user is unblocked
Remove autoblocks when a user is unblocked
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User blocking (Other open bugs)
unspecified
All All
: High enhancement with 10 votes (vote)
: 1.20.0 release
Assigned To: Nobody - You can work on this!
: schema-change
Depends on:
Blocks: 4618
  Show dependency treegraph
 
Reported: 2006-04-04 12:03 UTC by Rotem Liss
Modified: 2014-11-18 18:07 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
patch for unblocking autoblocked IPs when unblocking user (1.72 KB, patch)
2006-04-05 19:12 UTC, Max Semenik
Details
Patch (6.54 KB, patch)
2008-06-30 18:12 UTC, Max Semenik
Details

Description Rotem Liss 2006-04-04 12:03:57 UTC
Sometimes, we block a user, he tries to edit a page and his IP address is
automatically blocked, then we unblock him and forget to unblock his IP address
- or we waste our time by searching the automatically-blocked addresses to
unblock them.

I suggest to automatically unblock the automatically-blocked IP address, when
unblocking a user.
Comment 1 Max Semenik 2006-04-05 19:12:15 UTC
Created attachment 1503 [details]
patch for unblocking autoblocked IPs when unblocking user

I guess this patch can help. Though it uses some hacks.
Comment 2 Platonides 2006-04-11 11:09:17 UTC
I think it would be more valuable having mediazilla showing at the unblocking a
list like:

This block produced the following automatically blocks:
*127.0.0.1 (unblock)
*#4564 (unblock)
*127.0.0.2 (unblock)
*etc.

where unblock is a link to automatically unblock that user/ip. Maybe with an
auto reason "Unblocking autoblock done due to <ip originally blocked>"
Comment 3 Max Semenik 2008-06-30 18:12:28 UTC
Created attachment 5036 [details]
Patch

Here's my proposed fix. It changes the meaning of ipb_user - now it is set to id of user who caused the autoblock instead of zero. I made removing autoblocks an option in unblock dialog, though in practice it should be used in 99% of cases so probably it won't hurt if that option is eliminated completely and autoblocks are always removed.

I need some advice regarding API format. I currently made it in form &removeautoblocks=1, and assume that autoblocks should be removed if that option is omitted, but this probably contradicts with the current API practice where it usually looks simply like &removeautoblocks. But I wanted this option to be active by default.
Comment 4 Max Semenik 2008-10-11 12:15:58 UTC
Maybe, it'll get noticed on Bug Monday?
Comment 5 Mike.lifeguard 2008-11-22 19:25:01 UTC
(In reply to comment #3)
> Created an attachment (id=5036) [details]
> Patch
> 
> I need some advice regarding API format. I currently made it in form
> &removeautoblocks=1, and assume that autoblocks should be removed if that
> option is omitted, but this probably contradicts with the current API practice
> where it usually looks simply like &removeautoblocks. But I wanted this option
> to be active by default.
> 

Why can't you have it enabled by default for api, and use &noremautoblocks to *not* remove them?
Comment 6 John Mark Vandenberg 2011-04-28 14:32:17 UTC
Massive time saver here.  patch is a bit rotten, but can be saved..
Comment 7 John Du Hart 2011-09-01 02:51:43 UTC
Comment on attachment 5036 [details]
Patch

Marking this patch as obsolete. Unfortunately (Or fortunately, depending on your viewpoint =) ) the Block class has been refactored and no longer allows arbitrary setting of properties.
Comment 8 Liangent 2012-02-15 07:25:41 UTC
I propose to reuse the ipb_auto field and change it to an unsigned int: when it's 0, this block is manual; when it's not 0, it's an auto block created from a manual block whose number is ipb_auto.
Comment 9 Marc A. Pelletier 2012-03-28 04:03:15 UTC
Possible implementation submitted for review (Gerrit change #3841)

- New column instead of overloading ipb_auto for saner migration (per Tim)
- No option to not remove the autoblocks at the moment; honestly, I can't think of a scenario where this would make sense.
Comment 10 Antoine "hashar" Musso (WMF) 2012-05-04 06:40:23 UTC
Merged. Should be released with 1.20.

Thanks Mark!
Comment 11 Antoine "hashar" Musso (WMF) 2012-05-04 06:43:41 UTC
CREDITS / RELEASE-NOTES update made with https://gerrit.wikimedia.org/r/3841
Comment 12 Marcin Cieślak 2012-06-21 13:50:07 UTC
*** Bug 31893 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links