Last modified: 2013-10-09 01:11:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56314, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54314 - VisualEditor: A pawn appears when undoing "select transclusion and replace with text"
VisualEditor: A pawn appears when undoing "select transclusion and replace wi...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: High major
: VE-deploy-2013-10-03
Assigned To: Inez Korczyński
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-19 11:11 UTC by Krinkle
Modified: 2013-10-09 01:11 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2013-09-19 11:11:46 UTC
Steps to reproduce bug:
1. Edit a page
2. Insert a transclusion, apply changes
# The transclusion is now selected (VE does this automatically for newly inserted nodes)
3. Type a characters
# Selected content is removed, text is inserted
4. Undo

The expected result is the text being replaced with the transclusion. Instead a pawn is inserted.

Upon further inspection I noticed that the transclusion isn't lost, however. In fact it is right there when you Undo again (after getting the pawn).

So it looks like the pawn was inserted as a transaction in the middle of removing the transclusion (its own transaction but not supposed to be?) and inserting the text.

We auto-select the template after insertion and it is relatively easy to accidentally press a key afterwards. And Undo then shows the user something scary (their template appears lost). A fairly high priority bug regarding user experience.

Not sure if this is a regression or not.
Comment 1 James Forrester 2013-10-03 23:58:18 UTC
This is now fixed, AFAICS. Marking as such.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links