Last modified: 2014-11-15 07:45:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56180, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54180 - Visiting non existent banners shouldn't result in an exception
Visiting non existent banners shouldn't result in an exception
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CentralNotice (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Glaisher
:
: 70213 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-16 19:41 UTC by Sam Reed (reedy)
Modified: 2014-11-15 07:45 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2013-09-16 19:41:56 UTC
https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/2009_EM1Notice_b

2013-09-16 19:40:47 mw1161 metawiki: [e62cf2b2] /wiki/Special:CentralNoticeBanners/edit/2009_EM1Notice_b   Exception from line 1272 of /usr/local/apache/common-local/php-1.22wmf17/extensions/CentralNotice/includes/Banner.php: Banner doesn't exist!
#0 /usr/local/apache/common-local/php-1.22wmf17/extensions/CentralNotice/special/SpecialCentralNoticeBanners.php(347): Banner::getBannerSettings('2009_EM1Notice_...', true)
#1 /usr/local/apache/common-local/php-1.22wmf17/extensions/CentralNotice/special/SpecialCentralNoticeBanners.php(312): SpecialCentralNoticeBanners->generateBannerEditForm('2009_EM1Notice_...')
#2 /usr/local/apache/common-local/php-1.22wmf17/extensions/CentralNotice/special/SpecialCentralNoticeBanners.php(75): SpecialCentralNoticeBanners->showBannerEditor()
#3 /usr/local/apache/common-local/php-1.22wmf17/includes/SpecialPage.php(631): SpecialCentralNoticeBanners->execute('edit/2009_EM1No...')
#4 /usr/local/apache/common-local/php-1.22wmf17/includes/SpecialPageFactory.php(489): SpecialPage->run('edit/2009_EM1No...')
#5 /usr/local/apache/common-local/php-1.22wmf17/includes/Wiki.php(291): SpecialPageFactory::executePath(Object(Title), Object(RequestContext))
#6 /usr/local/apache/common-local/php-1.22wmf17/includes/Wiki.php(590): MediaWiki->performRequest()
#7 /usr/local/apache/common-local/php-1.22wmf17/includes/Wiki.php(459): MediaWiki->main()
#8 /usr/local/apache/common-local/php-1.22wmf17/index.php(55): MediaWiki->run()
#9 /usr/local/apache/common-local/w/index.php(3): require('/usr/local/apac...')
#10 {main}
Comment 1 Peter Coombe 2014-08-30 17:50:30 UTC
*** Bug 70213 has been marked as a duplicate of this bug. ***
Comment 2 Peter Coombe 2014-08-30 17:52:09 UTC
As suggested on bug 70213 the user should see a more friendly message similar to [[MediaWiki:Noarticletext]]
Comment 3 Gerrit Notification Bot 2014-08-30 22:35:38 UTC
Change 157484 had a related patch set uploaded by Ori.livneh:
Show a friendly error page when requested banner does not exist

https://gerrit.wikimedia.org/r/157484
Comment 4 Gerrit Notification Bot 2014-10-21 17:37:35 UTC
Change 157484 merged by jenkins-bot:
Show a friendly error page when requested banner does not exist

https://gerrit.wikimedia.org/r/157484
Comment 5 Glaisher 2014-11-13 17:50:02 UTC
(In reply to Gerrit Notification Bot from comment #4)
> Change 157484 merged by jenkins-bot:
> Show a friendly error page when requested banner does not exist
> 
> https://gerrit.wikimedia.org/r/157484

This doesn't work and results in an error still.
Comment 6 Glaisher 2014-11-14 18:13:28 UTC
I'll try to take a look.
Comment 7 Gerrit Notification Bot 2014-11-14 18:19:21 UTC
Change 173323 had a related patch set uploaded by Glaisher:
Show a friendly error page when requested banner does not exist

https://gerrit.wikimedia.org/r/173323
Comment 8 Gerrit Notification Bot 2014-11-14 20:09:59 UTC
Change 173323 merged by jenkins-bot:
Show a friendly error page when requested banner does not exist

https://gerrit.wikimedia.org/r/173323
Comment 9 Glaisher 2014-11-15 07:45:17 UTC
https://meta.wikimedia.beta.wmflabs.org/wiki/Special:CentralNoticeBanners/edit/asa  works.

Thanks for the merge, Ejegg.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links