Last modified: 2014-08-20 00:04:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56160, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54160 - Puppet files in Mediawiki-Vagrant should be re-usable outside of vagrant
Puppet files in Mediawiki-Vagrant should be re-usable outside of vagrant
Status: RESOLVED FIXED
Product: MediaWiki-Vagrant
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Low normal
: ---
Assigned To: Ori Livneh
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-16 07:09 UTC by Yuvi Panda
Modified: 2014-08-20 00:04 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Yuvi Panda 2013-09-16 07:09:06 UTC
Currently it has a few specific things that are run indiscriminately (like loading the kernel modules for vbox, etc) that don't make sense in other environments when it is run (Labs, or my new laptop (if I get one) where I plan on running the puppet files locally). Perhaps having them conditionally check if they are running on vbox before loading those?
Comment 1 Ori Livneh 2013-09-16 07:10:10 UTC
Agreed; I'll work on it.
Comment 2 Gerrit Notification Bot 2013-09-16 21:23:00 UTC
Change 84431 had a related patch set uploaded by Ori.livneh:
Box Virtualbox-specific configs in 'virtualbox' module

https://gerrit.wikimedia.org/r/84431
Comment 3 Gerrit Notification Bot 2013-09-24 00:43:38 UTC
Change 84431 merged by jenkins-bot:
Box Virtualbox-specific configs in 'virtualbox' module

https://gerrit.wikimedia.org/r/84431
Comment 4 Ori Livneh 2013-09-24 00:59:15 UTC
Yuvi, can we close this now, or are there additional requirements?
Comment 5 Yuvi Panda 2013-09-24 01:00:42 UTC
I'm checking, by running it outside of vbox (in Labs).

So far I've run into issues with the puppet files assuming that a 'vagrant' user exists. I'm also not sure if the apt-cache stuff should be used outside of virtualbox.
Comment 6 Yuvi Panda 2013-09-24 03:15:13 UTC
So, the only two errors I get when running this in labs is:

err: Removing mount volatile: /var/lib/puppet/volatile does not exist or is not a directory

and 

err: Removing mount software: /etc/puppet/software does not exist or is not a directory

Possibly caused by facter conflicts?

It works otherwise.
Comment 7 Bryan Davis 2014-08-20 00:04:19 UTC
I'm going to mark this as resolved since MediaWiki-Vagrant is usable in labs. 

There are definitely still "Vagrantisms" in the puppet roles that can be hunted down and removed as we migrate more things to use hiera variables and the "environment" switch. I don't think this bug represents those potential concerns well however. Specific bug reports (and patches!) would be welcome.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links