Last modified: 2014-08-15 12:56:39 UTC
In Firefox 23 and other FF versions the browser search (Ctrl + F) does not work as the code in the editor is not part of the search. Especially when editing long code the search function is important.
Any testcase available? Entering a few random lines on https://en.wikipedia.org/w/index.php?title=User:AKlapper_%28WMF%29/Whatever.js&action=edit and then searching for them works for me in Firefox 23.0.1 on Fedora 19, but maybe I misunderstand the problem?
The search does not work because all hidden lines are out off what the navigator can search. But CE adds a search tool for code area, just use it (Ctrl+F when the focus is on the code area).
See Comment 2, the lines that are not currently shown on the screen are not subject to the browser search. The CE search is quite useless as it finds the first occurance of a string only. After the first match I cannot continue the search for a second string. Also, search & replace is not available.
(In reply to comment #3) > Also, search & replace is not available. Separate issue...
The search in https://gerrit.wikimedia.org/r/104510 is much improved. And using ctrl-f keycombo twice exposes the replace function. It also has regexp capabilities now and incremental search automatically highlights any match in the editor as you type. I think that should take care of most concerns.
I'd love to hear some feedback on what people think about this now..
Another problem with the search tool from CodeEditor is that it doesn't work immediately after I press CTRL+F, causing the text to be inserted in the JS code instead of its search box, which is annoying.
