Last modified: 2010-05-15 15:37:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T7374, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 5374 - Single quotes in RSS field cause issues


Summary:	Single quotes in RSS field cause issues

Status:	CLOSED WORKSFORME

Product:	MediaWiki
Classification:	Unclassified
Component:	Special pages (Other open bugs)
Version:	1.5.x
Hardware:	PC All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2006-03-27 16:57 UTC by Aaron Axelsen
Modified:	2010-05-15 15:37 UTC (History)
CC List:	0 users

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Aaron Axelsen 2006-03-27 16:57:29 UTC

The single quotes used to include the rss/atom links in line 878 and 880 of
includes/OutputPage.php cause firefox to not detect that there is a feed on the
page.  This may affect other things as well.

The fix is to just change the linkes to use " as follows:

878: 
$ret .= "<link rel=\"alternate\" type=\"application/rss+xml\" title=\"RSS 2.0\"
href=\"$link\" />\n";

880: 
$ret .= "<link rel=\"alternate\" type=\"application/atom+xml\" title=\"Atom
0.3\" href=\"$link\" />\n";

Comment 1 Brion Vibber 2006-03-27 18:20:08 UTC

Firefox 1.5 sees the RSS feed and shows it's little orange link
in the URL bar at eg http://en.wikipedia.org/wiki/Special:Recentchanges.

If you have some odd version of Firefox where this doesn't work,
you can report bugs to the Mozilla team at http://bugzilla.mozilla.org/

Comment 2 Aaron Axelsen 2006-03-31 14:45:29 UTC

I have also tested this, and it seems to work.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links