Last modified: 2014-08-17 11:42:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55739, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53739 - wmgHTTPSBlacklistCountries changes for CN
wmgHTTPSBlacklistCountries changes for CN
Status: NEW
Product: Wikimedia
Classification: Unclassified
SSL related (Other open bugs)
wmf-deployment
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-04 07:58 UTC by Liangent
Modified: 2014-08-17 11:42 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Liangent 2013-09-04 07:58:00 UTC
It was reported by users that HTTPS block in China was only for Wikipedia, thus the following change is proposed, given the current policy of having the best security while trying to keep access for logged-in users in China.

'wmgHTTPSBlacklistCountries' => array(
	'default' => array(
		'IR', // Iran
	),
	'wikipedia' => array(
		'CN', // China
		'IR', // Iran
	),
),
Comment 1 Andre Klapper 2013-09-10 14:58:09 UTC
(In reply to comment #0)
> It was reported by users that HTTPS block in China was only for Wikipedia

Any URL (if that question makes sense & does not create problems for anybody)?
Comment 2 Liangent 2013-09-10 15:51:34 UTC
(In reply to comment #1)
> (In reply to comment #0)
> > It was reported by users that HTTPS block in China was only for Wikipedia
> 
> Any URL (if that question makes sense & does not create problems for
> anybody)?

Hmm... it's even blocked in the other way for some other sites:

https://zh.greatfire.org/zh.wikisource.org (blocked)
https://zh.greatfire.org/https/zh.wikisource.org (not blocked)
Comment 3 Liangent 2013-09-10 15:57:08 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > (In reply to comment #0)
> > > It was reported by users that HTTPS block in China was only for Wikipedia
> > 
> > Any URL (if that question makes sense & does not create problems for
> > anybody)?
> 
> Hmm... it's even blocked in the other way for some other sites:
> 
> https://zh.greatfire.org/zh.wikisource.org (blocked)
> https://zh.greatfire.org/https/zh.wikisource.org (not blocked)

I guess I'd better provide English links:

https://en.greatfire.org/zh.wikisource.org (blocked)
https://en.greatfire.org/https/zh.wikisource.org (not blocked)
Comment 4 Andre Klapper 2013-09-18 17:25:13 UTC
Liangent: Willing to come up with a patch?
Comment 5 Sam Reed (reedy) 2013-09-18 18:38:48 UTC
'wmgHTTPSBlacklistCountries' => array(
    'default' => array(
        'IR', // Iran
    ),
    '+wikipedia' => array(
        'IR', // Iran
    ),
),


^ I guess that's the patch...
Comment 6 Gerrit Notification Bot 2013-09-18 18:40:15 UTC
Change 84781 had a related patch set uploaded by Reedy:
wmgHTTPSBlacklistCountries changes for CN

https://gerrit.wikimedia.org/r/84781
Comment 7 Gerrit Notification Bot 2013-09-20 18:40:55 UTC
Change 84781 merged by jenkins-bot:
wmgHTTPSBlacklistCountries changes for CN

https://gerrit.wikimedia.org/r/84781
Comment 8 Liangent 2013-09-29 12:39:16 UTC
(In reply to comment #7)
> Change 84781 merged by jenkins-bot:
> wmgHTTPSBlacklistCountries changes for CN
> 
> https://gerrit.wikimedia.org/r/84781

Is this correctly patched & deployed?

It seems zhwikibooks behaves correctly but wikidatawiki and commonswiki don't. It seems we should use 'wikipedia' instead of 'wiki' or it might be a suffix match.
Comment 9 Andre Klapper 2013-11-22 15:39:26 UTC
Liangent: Situation is still as described in comment 8?
Comment 10 Andre Klapper 2014-01-09 12:29:59 UTC
Liangent: Situation is still as described in comment 8?
Comment 11 Liangent 2014-01-09 19:20:26 UTC
(In reply to comment #10)
> Liangent: Situation is still as described in comment 8?

OK but it's reported by users that HTTPS is not blocked at all now...
Comment 12 Andre Klapper 2014-03-20 13:39:05 UTC
Liangent: Did your "OK" mean "Yes" or "Oh well"? :)
Comment 13 Liangent 2014-03-21 19:05:10 UTC
(In reply to Andre Klapper from comment #12)
> Liangent: Did your "OK" mean "Yes" or "Oh well"? :)

I can't check it now but per user reports, the current situation is that:

* Desktop sites: no block at all
* Mobile sites: all projects are blocked

... and this can't be described with our configuration array. :/

Should we still be playing this cat & mouse game?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links