Last modified: 2014-04-30 03:00:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55689, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 53689 - Tool Labs: Local webservice should know about HTTPS in original request
Tool Labs: Local webservice should know about HTTPS in original request
Status: RESOLVED FIXED
Product: Wikimedia Labs
Classification: Unclassified
tools (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Marc A. Pelletier
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-09-02 20:50 UTC by Liangent
Modified: 2014-04-30 03:00 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Liangent 2013-09-02 20:50:46 UTC 
See https://tools.wmflabs.org/liangent-php/detectProtocol.php/enwiki

Feel free to move this bug to MediaWiki product if there's some reliable way to check so there while MediaWiki is unaware of it.
Comment 1 Liangent 2013-09-02 21:02:45 UTC 
(Consequently this causes a redirect loop in MediaWiki installations on Tool-Lab with $wgSecureLogin = true; and this is why I spotted it)
Comment 2 Marc A. Pelletier 2013-09-02 21:22:20 UTC 
Ah, interesting.  The communication between the proxy and the internal webservers currently occur through HTTP over the (virtual) network (with the proxy taking care of encryption) -- it's not immediately clear to me how this could be hidden from the application.
Comment 3 Dan Michael Heggø 2013-12-09 15:35:59 UTC 
Is it possible to configure the proxy to add X-Forwarded-Proto, like http://www.geekisp.com/faq/6_65_en.html ?
Comment 4 Marc A. Pelletier 2013-12-09 15:53:25 UTC 
Hm; that should be simple enough actually.  Lemme see what I can do.
Comment 5 Marc A. Pelletier 2013-12-09 16:44:27 UTC 
And indeed, it was.  The X-Forwarded-Proto header should now be present.
Comment 6 Krinkle 2014-03-17 02:15:17 UTC 
Looks like this doesn't work anymore, may or may not be caused by tools being additionally proxied to tools-eqiad.

https://tools.wmflabs.org/blankpages/_server.php

    [HTTP_X_FORWARDED_PROTO] => http
Comment 7 Liangent 2014-04-30 02:59:19 UTC 
Seems fixed
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links