Last modified: 2010-05-15 15:37:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 5357 - Add the icon near the user name also in RTL interfaces
Add the icon near the user name also in RTL interfaces
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.5.x
All All
: Normal trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-03-26 16:05 UTC by Rotem Liss
Modified: 2010-05-15 15:37 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch for CVS HEAD (723 bytes, patch)
2006-03-26 16:07 UTC, Rotem Liss
Details
Patch for REL1_5 (728 bytes, patch)
2006-03-26 16:23 UTC, Rotem Liss
Details

Description Rotem Liss 2006-03-26 16:05:34 UTC
Nowadays, the icon near the user name is disabled in RTL interfaces, but we in
Hebrew Wikipedia, Wikiquote and Wikisource re-added it in our Monobook.css, and
it works well. I suggest to cancel the hidding of it also in the global rtl.css.

I will create a patch soon.
Comment 1 Rotem Liss 2006-03-26 16:07:27 UTC
Created attachment 1466 [details]
Patch for CVS HEAD

Patch, deletes the CSS part in "rtl.css" which hides the icon. I've tested the
patch and it works well, just like Wikipedia.
Comment 2 Rotem Liss 2006-03-26 16:09:18 UTC
Comment on attachment 1466 [details]
Patch for CVS HEAD

This is a patch for HEAD, or MAIN, or something like that (the main tree, where
version 1.6 is developed, and which Wikimedia projects use). Patch for REL1_5
is coming soon.
Comment 3 Rob Church 2006-03-26 16:15:47 UTC
Observing a fresh RTL test wiki, it doesn't appear that the icon is hidden at all.
Comment 4 Rotem Liss 2006-03-26 16:17:41 UTC
(In reply to comment #3)
> Observing a fresh RTL test wiki, it doesn't appear that the icon is hidden at all.

Are you trying the recent 1.6cvs (alpha) version? Also, please check
skins/monobook/rtl.css for the string "pt-userpage".
Comment 5 Rotem Liss 2006-03-26 16:18:25 UTC
(In reply to comment #4)
> Are you trying the recent 1.6cvs (alpha) version? Also, please check
> skins/monobook/rtl.css for the string "pt-userpage".

And please see:
* http://he.wiktionary.org
* http://he.wikibooks.org
* http://he.wikinews.org
Comment 6 Rotem Liss 2006-03-26 16:23:09 UTC
Created attachment 1467 [details]
Patch for REL1_5

Patch for REL1_5.
Comment 7 Rotem Liss 2006-03-26 16:26:47 UTC
And directly, please see:
http://cvs.sourceforge.net/viewcvs.py/wikipedia/phase3/skins/monobook/rtl.css?view=markup

Search the line "/* Fix link icons */" - the line after that cancels the icon.

Does your installed Wiki use rtl.css?
Comment 8 Rob Church 2006-03-26 17:06:24 UTC
1. Using MediaWiki 1.6alpha
2. It's a Yiddish language RTL wiki
3. rtl.css appears to be being imported

http://www.anubite.co.uk/wikis/yiddish
Comment 9 Rotem Liss 2006-03-26 17:20:34 UTC
(In reply to comment #8)
> 1. Using MediaWiki 1.6alpha
> 2. It's a Yiddish language RTL wiki
> 3. rtl.css appears to be being imported
> 
> http://www.anubite.co.uk/wikis/yiddish
> 

Like in Hebrew Wikipedia, Wikiquote and Wikisource, it contains the following
CSS sector in Monobook.css:

li#pt-userpage,
li#pt-anonuserpage,
li#pt-login {
    background:  url('http://yi.wikipedia.org/style/monobook/user.gif') top left
no-repeat;
    padding-left: 20px;
}

This monobook.css is copied from Yiddish Wikipedia, which has also fixed the
problem.
Comment 10 Rob Church 2006-03-26 17:27:56 UTC
Quite correct. I apologise.
Comment 11 Rob Church 2006-03-26 18:33:56 UTC
Tested on a fresh install and applied to CVS HEAD.
Comment 12 Rotem Liss 2006-03-27 13:11:04 UTC
Could you please fix it also in CVS REL1_5? It's very minor, and I've tested the
patch on a fresh install of recent 1.5cvs files.
Comment 13 Rotem Liss 2006-04-06 07:42:31 UTC
It's already in the stable version, so there is no need to fix it in REL1_5.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links