Last modified: 2014-02-12 23:46:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55342, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 53342 - Improve Error handling of GeoLocation api
Improve Error handling of GeoLocation api
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
Feature requests (Other open bugs)
unspecified
All All
: Low enhancement
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-08-26 13:58 UTC by Derk-Jan Hartman
Modified: 2014-02-12 23:46 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Derk-Jan Hartman 2013-08-26 13:58:31 UTC 
Currently the code simply prints an error. This error however doesn't take into account the cause of the geolocation failure. I was getting messages that my signal wasn't good, but the true reason was that I had simply disable all Safari location permissions. I was genuinely confused.

So in the nearby.js error handler, pass the error to the error handler and print appropriate messages depending on the cause of the failure:

https://developer.mozilla.org/en-US/docs/Web/API/PositionError
Comment 1 Jon 2013-08-26 15:24:51 UTC 
Yeh this would be a good idea. Our error handling is currently a little lazy.
Comment 2 Gerrit Notification Bot 2013-09-16 22:57:15 UTC 
Change 84459 had a related patch set uploaded by Jdlrobson:
Improve nearby error handling

https://gerrit.wikimedia.org/r/84459
Comment 3 Gerrit Notification Bot 2013-09-23 20:56:31 UTC 
Change 84459 merged by jenkins-bot:
Improve nearby error handling

https://gerrit.wikimedia.org/r/84459
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links