Last modified: 2013-10-28 18:04:17 UTC
cucumber features/visual_editor_anon.feature:5 # Scenario: Basic edit fails because VisualEditor these days shows an introductory disclaimer: This is our new, easier way to edit. It's still in beta, which means you might find parts of the page you can't edit... and so it fails with expected "You are not currently logged in. which isn't visible until you dismiss the popup. I think the same explains a timed out after 5 seconds, Element was not visible in 5 seconds that I'm getting in the similar cucumber features/visual_editor_logged_in.feature:5 # Scenario: Basic edit after applying Gerrit change #80709. The popup is in a div containing an iframe containing more divs until class="ve-ui-mwBetaWelcomeDialog-content", and then tests have to click outside it to dismiss it; and some day it will go away. Instead it seems better to set the ve-beta-welcome-dialog cookie to 1 upon visiting the site, which will turn off this disclaimer dialog.
I've been running these tests against test2wiki, which doesn't have that problem. https://gerrit.wikimedia.org/r/#/c/80709/ should make it possible to run these against beta labs now that VE seems to be deployed there reliably
Also note that the beta welcome message will be rolled out to all wikis soon.
When it shows up on test2 and/or beta I'll dismiss it in the test. Why is VE using an iframe for this? (and using iframes in general?)
(In reply to comment #3) > Why is VE using an iframe for this? (and using iframes in general?) For the welcome message, we don't technically need to use an iframe. In that case we just use an iframe because all of our other dialogs use iframes. In general, we use iframes for dialogs and inspectors because we need to be able to have two selections at the same time. For instance, when you inspect a link, the link is selected, but you also have a cursor in the text field in the inspector. Because you can only have one selection in any given HTML document, we need the edit surface and the text field to be in different documents, and so we put the text field (along with most of the rest of the inspector) in an iframe. Dialogs use iframes for similar reasons: when the user interacts with UI elements in the dialog, that needs to not affect their selection in the edit surface. The welcome dialog doesn't have any elements that can steal the focus or selection so it's not an issue there, but since it uses the generic dialog code it's automatically in an iframe.
Should this be closed since 80709 is merged into master?
(In reply to comment #5) > Should this be closed since 80709 is merged into master? No, that's a different problem breaking VE tests. Please can you change the VE tests to have an If there is an introductory welcome message then dismiss it stanza?
Honestly, I would rather that VE behave the same on beta, test2wiki, and production. Preferably at more or less the same time.
Chris, this is fixed, right? Is there anything left here to do? Should we close the bug?
fixed
