Last modified: 2014-03-17 17:30:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T55214, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 53214 - VisualEditor: Slugs are created inside empty table rows, creating pawns if used
VisualEditor: Slugs are created inside empty table rows, creating pawns if used
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-03-20
Assigned To: Ed Sanders
:
Depends on:
Blocks: ve-tablesupport
  Show dependency treegraph
 
Reported: 2013-08-22 15:12 UTC by Chris McKenna
Modified: 2014-03-17 17:30 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chris McKenna 2013-08-22 15:12:31 UTC
At https://en.wikipedia.org/w/index.php?title=Churnet_Valley_Railway&diff=prev&oldid=569277862 it seems that a table ending with trailing new line syntax

|-
|}

caused pawns to be added to the article. As discussed at https://en.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/Feedback&oldid=569732999#Chess_pieces_still_happening this syntax, although technically wrong, will continue to be added to articles. VE and Parsoid should therefore deal with this cleanly without the addition of any pawns to the article.
Comment 1 Gabriel Wicke 2013-08-22 15:40:19 UTC
Pawns are firmly VE territory. Moving to the VisualEditor product.
Comment 2 Chris McKenna 2013-08-23 18:32:37 UTC
To perhaps clarify, VE and parsoid should accept both

|content
|-
|}

and

|content
|}

as validly closed templates that should be displayed and rendered identically. Both syntaxes should be retained as is when roundtripping.
Comment 3 Gabriel Wicke 2013-08-23 22:08:46 UTC
(In reply to comment #2)
> To perhaps clarify, VE and parsoid should accept both
> 
> |content
> |-
> |}
> 
> and
> 
> |content
> |}
> 
> as validly closed templates that should be displayed and rendered
> identically.

We currently don't strip empty table rows, which seems to be done in some conditions in the PHP parser + tidy combo. We could emulate this behavior in templated content and maybe also outside of templated content, but will need to avoid dirty diffs and preserve WYSIWYG behavior even when another row is added in VE.

> Both syntaxes should be retained as is when roundtripping.

This should already be the case in Parsoid. I just verified this at http://parsoid.wmflabs.org/_rtform/. Pawn insertion would a DOM modification in VE.
Comment 5 Gerrit Notification Bot 2014-03-17 16:18:31 UTC
Change 119067 had a related patch set uploaded by Esanders:
Only insert slugs where paragraphs are allowed

https://gerrit.wikimedia.org/r/119067
Comment 6 Gerrit Notification Bot 2014-03-17 17:20:19 UTC
Change 119067 merged by jenkins-bot:
Only insert slugs where paragraphs are allowed

https://gerrit.wikimedia.org/r/119067

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links