Last modified: 2007-01-11 18:37:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T7301, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 5301 - select_position Database Call Broken
select_position Database Call Broken
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
GIS (Other open bugs)
unspecified
PC Linux
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2006-03-21 01:29 UTC by Gregory Szorc
Modified: 2007-01-11 18:37 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Gregory Szorc 2006-03-21 01:29:33 UTC 
On line 230 of the most recent version of database.php a call to array_merge is
made.  The first argument to this function is a string, where it should be an
array.  This causes the WHERE statement to be truncated to nothing.  To fix
this, change the line to read:

array_merge(array($condition) , array( 'page_id = gis_page' ) )

I am not sure if earlier versions of PHP allow a parameter to be a string, but I
can definitely say there is an issue with PHP 5.1.x.
Comment 1 Greg Sabino Mullane 2007-01-11 18:37:11 UTC 
This has already been fixed in subversion. At least, it appears that
database.php has been split into GisDatabase.php and geo.php, and neither of
them now use array_merge. Thanks for the report.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links