Last modified: 2014-02-24 18:25:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54562, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52562 - Gadgets: Add support to understand whether a gadget supports VisualEditor (or another feature?) and allow it to be greyed out
Gadgets: Add support to understand whether a gadget supports VisualEditor (or...
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
Gadgets (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on: 53584
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-05 21:22 UTC by Technical 13
Modified: 2014-02-24 18:25 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Technical 13 2013-08-05 21:22:42 UTC
[15:52] <T13> VE Question.  How is VE currently set up to handle users that have opted-in to gadgets that modify the editing window such as wikEd?
...
[15:54] <T13> Do those gadgets still load even though the hooks they use don't exist? Shouldn't having VE enabled disable those gadgets and grey out the optiobs for them in the gadgets tab of preferences?
[15:56] <T13> I'm guessing some of the "VE" bugs are caused by these gadgets trying to do what they no longer can.
...
[16:06] <mooeypoo> T13: I think most of the edit-related gadgets work on the action=edit condition, and ve goes with action=vedit
[16:07] <mooeypoo> but I am not sure :) you'll be safer getting the answer from the VE team
[16:09] <MatmaRex> T13: i'm not on the team, but i'm pretty sure that's the reason
[16:10] <MatmaRex> T13: basically there are two ways to detect if we're inedit mode - either look if 'action' is 'edit' or 'submit', or look for some elements that are parts of theedit form, like #wpTextbox1 (the main textbox)
[16:10] <MatmaRex> VE avoids them both
[16:11] <T13> I've seen questions on WP:THQ with a link to a screenshot of wikEd and the user thinking they were using VE.  So, I was curious how it was handled.
[16:11] <T13> I'll add the suggestion to gray out the unusable with VE gadgets 
[16:11] <mooeypoo> Ah, *that* kind of user errors. Hm. Not sure how you can handle those other than politely correct the user's false assumption
[16:11] <T13> On Bugzilla...
Comment 1 James Forrester 2013-08-06 00:01:04 UTC
Not sure what the bug is, here?

Gadgets can be written to work with VisualEditor, but gadgets not written to do so won't work, and dated (and so now misleading) advertising on behalf of these gadgets that it works with "the editor" will confuse people.

As normal, gadget authors and maintainers should make sure that they re-label their gadgets to avoid this confusion.

Or am I missing something?
Comment 2 James Forrester 2013-08-30 02:08:25 UTC
Closing as INVALID as no response after 3 weeks (but happy to reconsider if I've mis-understood).
Comment 3 Technical 13 2013-08-30 12:21:23 UTC
(In reply to comment #1)
> Not sure what the bug is, here?
> 
> Gadgets can be written to work with VisualEditor, but gadgets not written to
> do so won't work, and dated (and so now misleading) advertising on behalf of
> these gadgets that it works with "the editor" will confuse people.
> 
> As normal, gadget authors and maintainers should make sure that they re-label
> their gadgets to avoid this confusion.
> 
> Or am I missing something?

I'm sorry James, I missed your question.  I've uploaded a couple screenshots of what I'm thinking (although I'm thinking this may require a change in the gadgets extension first on second thought).

Currently, the "Editing" section of the gadgets tab on enwp looks like:
   [[commons:File:Special_Preferences_mw-prefsection-gadgets_%28current%29.png]]

What I'm proposing, is that when VisualEditor is active for the user, it should look like:
   [[commons:File:Special_Preferences_mw-prefsection-gadgets_%28proposed%29.png]]

With the options for things like dot's highlighter and wikiEd grayed out so they can't be clicked (and defaulted to off).
Comment 5 James Forrester 2013-11-01 05:05:48 UTC
Hmm. Not totally convinced by this - (a) because this is inherently transitional as gadgets are updated to work with VisualEditor, and (b) because disabling gadgets that work fine, just not in all places, seems a bit unfair. Re-titling and moving to the Gadgets pile, however.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links