Last modified: 2014-09-12 20:26:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54363, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 52363 - Some non-table uses of {{pipe}} are not parsed correctly


Summary:	Some non-table uses of {{pipe}} are not parsed correctly

Status:	RESOLVED FIXED

Product:	Parsoid
Classification:	Unclassified
Component:	tokenizer (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Low normal
Target Milestone:	---
Assigned To:	C. Scott Ananian

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-07-31 23:09 UTC by C. Scott Ananian
Modified:	2014-09-12 20:26 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description C. Scott Ananian 2013-07-31 23:09:05 UTC

Because we parse templates in their own top-level context, the {{pipe}} template gets parsed as <td>... when in most of its uses it really wants to be just a plain pipe character.  Eg:

!! test
Plain pipe
!! input
{{pipe}}
!! result
|
!! end

Comment 1 Gerrit Notification Bot 2013-08-02 17:23:31 UTC

Change 77352 had a related patch set uploaded by Cscott:
Add parser tests for bug 52468 and bug 52363.

https://gerrit.wikimedia.org/r/77352

Comment 2 Gerrit Notification Bot 2013-08-02 19:30:42 UTC

Change 77352 merged by jenkins-bot:
Add parser tests for bug 52468 and bug 52363.

https://gerrit.wikimedia.org/r/77352

Comment 3 Gabriel Wicke 2013-08-13 18:08:19 UTC

(In reply to comment #0)
> Because we parse templates in their own top-level context, the {{pipe}}
> template gets parsed as <td>... when in most of its uses it really wants to
> be
> just a plain pipe character.

Do you have data to support the 'in most of its uses' claim? I'd be surprised if that was the case.

Comment 4 Technical 13 2013-08-13 18:16:11 UTC

Perhaps you're confusing {{pipe}} for {{!}} ?

Comment 5 C. Scott Ananian 2013-08-13 20:10:56 UTC

@Gwicke and @Technical 13 -- I'm solely talking about parserTests.txt here.  I'm making no claims about general wikitext usage.

Comment 6 ssastry 2014-09-12 20:26:34 UTC

This has been fixed for a while now. The pipe chars outside tables are handled correctly whether as {{!}} or |

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links