Last modified: 2008-10-28 18:02:34 UTC
This extension uses the deprecated tag bgcolor. If you put bgcolor=transparent it doesn't works obviously. I think it would be very easy to change the code to generate style="background:<value>" instead of bgcolor="<value>". It's no necesary to change the name of the parameter.
There is no bgcolor tag.
(In reply to comment #1) > There is no bgcolor tag. No bgcolor tag? Please read http://meta.wikimedia.org/wiki/Help:Inputbox#Parameters bgcolor is the first parameter. See the code generated by <inputbox> type=search bgcolor=#eeeeff </inputbox> The bgcolor tag appears in <td ...> <table border="0" width="100%" cellspacing="0" cellpadding="0"> <tr> <td align="center" bgcolor="#eeeeff"> <form name="searchbox" action="/wiki/Especial:Search" class="searchbox" id="searchbox"> <p><input class="searchboxInput" name="search" type="text" value="" size="40" /><br /> <input type='submit' name="go" class="searchboxGoButton" value="Buscar título exacto" /> <input type='submit' name="fulltext" class="searchboxSearchButton" value="Buscar en el texto" /></p> </form> </td> </tr> </table>
There is no such thing as a bgcolor tag in HTML. There's a bgcolor attribute, though, on some elements. Is that what you meant? What specifically is the issue with it?
(In reply to comment #3) > There is no such thing as a bgcolor tag in HTML. There's a bgcolor > attribute, though, on some elements. Is that what you meant? What > specifically is the issue with it? > Yes, change "bgcolor tag" by "bgcolor attribute", this atribute is deprecated I only want the generated code by <inputbox> type=search bgcolor=transparent </inputbox> to be ... <td align="center" style="background:transparent;"> ... instead ... <td align="center" bgcolor="transparent"> ... I think it will be very easy. Thanks
Ah, I see what you mean. Changing summary... This would probably require some additional input validation. Please check existing usage of <inputbox> to see what kind of formats people are putting in there to date...
(Note: if some zealous committer is watching this bug report, DO NOT just change inputbox.php from bgcolor="{$this->bgcolor}" to style="background-color: {$this->bgcolor}". Repeat. DO NOT DO THIS. It would be a JavaScript injection point which could lead to session hijacking in Internet Explorer and Mozilla based browsers.)
(In reply to comment #6) Yes. Avoid, at least, " and ;
(In reply to comment #6) I believe that the present version is not free either of being a JS injection point, is it?
You believe incorrectly.
Should be fixed now with the various refactors over the last few days. The bgcolor param is now applied to the style attribute, rather than the bgcolor attribute.
