Last modified: 2008-10-28 18:02:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 5216 - Use more flexible CSS instead of bgcolor attribute for inputbox bgcolor option
Use more flexible CSS instead of bgcolor attribute for inputbox bgcolor option
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
InputBox (Other open bugs)
unspecified
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Trevor Parscal
http://meta.wikimedia.org/wiki/Help:I...
:
Depends on:
Blocks: css
  Show dependency treegraph
 
Reported: 2006-03-09 14:14 UTC by sanbec
Modified: 2008-10-28 18:02 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description sanbec 2006-03-09 14:14:42 UTC
This extension uses the deprecated tag bgcolor. If you put bgcolor=transparent
it doesn't works obviously. I think it would be very easy to change the code to
generate style="background:<value>" instead of bgcolor="<value>". It's no
necesary to change the name of the parameter.
Comment 1 Brion Vibber 2006-03-09 21:24:29 UTC
There is no bgcolor tag.
Comment 2 sanbec 2006-03-10 08:35:29 UTC
(In reply to comment #1)
> There is no bgcolor tag.

No bgcolor tag? Please read
http://meta.wikimedia.org/wiki/Help:Inputbox#Parameters bgcolor is the first
parameter. 

See the code generated by 
<inputbox>
type=search
bgcolor=#eeeeff
</inputbox>

The bgcolor tag appears in <td ...>

<table border="0" width="100%" cellspacing="0" cellpadding="0">
<tr>
<td align="center" bgcolor="#eeeeff">
<form name="searchbox" action="/wiki/Especial:Search" class="searchbox"
id="searchbox">
<p><input class="searchboxInput" name="search" type="text" value="" size="40"
/><br />
<input type='submit' name="go" class="searchboxGoButton" value="Buscar título
exacto" />&#160;<input type='submit' name="fulltext"
class="searchboxSearchButton" value="Buscar en el texto" /></p>
</form>
</td>
</tr>
</table>
Comment 3 Brion Vibber 2006-03-10 08:38:19 UTC
There is no such thing as a bgcolor tag in HTML. There's a bgcolor 
attribute, though, on some elements. Is that what you meant? What 
specifically is the issue with it?
Comment 4 sanbec 2006-03-10 08:55:33 UTC
(In reply to comment #3)
> There is no such thing as a bgcolor tag in HTML. There's a bgcolor 
> attribute, though, on some elements. Is that what you meant? What 
> specifically is the issue with it?
> 

Yes, change "bgcolor tag" by "bgcolor attribute", this atribute is deprecated

I only want the generated code by 

<inputbox>
type=search
bgcolor=transparent
</inputbox>

to be 
...
<td align="center" style="background:transparent;">
...

instead 

...
<td align="center" bgcolor="transparent">
...

I think it will be very easy. 

Thanks
Comment 5 Brion Vibber 2006-03-10 09:05:44 UTC
Ah, I see what you mean. Changing summary...

This would probably require some additional input validation. Please 
check existing usage of <inputbox> to see what kind of formats people 
are putting in there to date...
Comment 6 Brion Vibber 2006-03-10 09:12:46 UTC
(Note: if some zealous committer is watching this bug report,
DO NOT just change inputbox.php from bgcolor="{$this->bgcolor}" to 
style="background-color: {$this->bgcolor}". Repeat. DO NOT DO THIS.
It would be a JavaScript injection point which could lead to session 
hijacking in Internet Explorer and Mozilla based browsers.)
Comment 7 sanbec 2006-03-10 09:19:26 UTC
(In reply to comment #6)

Yes. Avoid, at least, " and ;  

Comment 8 sanbec 2006-03-10 16:19:47 UTC
(In reply to comment #6)

I believe that the present version is not free either of being a JS injection
point, is it?
Comment 9 Brion Vibber 2006-03-10 19:32:11 UTC
You believe incorrectly.
Comment 10 Chad H. 2008-10-28 18:02:34 UTC
Should be fixed now with the various refactors over the last few days. The bgcolor param is now applied to the style attribute, rather than the bgcolor attribute.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links