Last modified: 2013-07-31 21:29:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53919, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51919 - Table cell with pipe causes nowiki
Table cell with pipe causes nowiki
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: ssastry
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-24 02:19 UTC by John Mark Vandenberg
Modified: 2013-07-31 21:29 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description John Mark Vandenberg 2013-07-24 02:19:17 UTC
When a table cell contains a single pipe, nowiki is added around the single pipe.  Currently the single pipe in this scenario is not wikisytax, so it doesnt need to be wrapped in nowiki.

Steps to reproduce:
1. https://nl.wikipedia.org/wiki/Gebruiker:John_Vandenberg/test?veaction=edit
2. Modify 'Voor'
3. Review changes.

Result:
<nowiki> is added to line of text

This is a real life example at
https://nl.wikipedia.org/wiki/Ford_RS200?veaction=edit

Currently listed on:
http://parsoid.wmflabs.org:8001/topfails/3
Comment 1 ssastry 2013-07-24 03:35:37 UTC
Simplified test case for fixing and adding to parserTests:

[subbu@earth tests] echo "{|\n|foo\nbar|baz\n|}" | node parse --wt2wt
{|
|foo
<nowiki>bar|baz</nowiki>
|}

TD nowiki handler needs a newline check.
Comment 2 Gerrit Notification Bot 2013-07-24 20:21:12 UTC
Change 75767 had a related patch set uploaded by Subramanya Sastry:
(Bug 51919) Finetuning of td nowiki escape handler

https://gerrit.wikimedia.org/r/75767
Comment 3 Gerrit Notification Bot 2013-07-27 13:34:08 UTC
Change 75767 merged by jenkins-bot:
(Bug 51919) Finetuning of td nowiki escape handler

https://gerrit.wikimedia.org/r/75767
Comment 4 ssastry 2013-07-31 21:29:01 UTC
Deployed and tested in production.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links