Last modified: 2011-04-04 21:32:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T7129, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 5129 - Disabled InnoDB engine and "no substitution" SQL mode yields installation error
Disabled InnoDB engine and "no substitution" SQL mode yields installation error
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Database (Other open bugs)
1.5.x
All other
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-02-28 16:21 UTC by Björn Wiberg
Modified: 2011-04-04 21:32 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Björn Wiberg 2006-02-28 16:21:12 UTC
When MySQL is configured with sql-mode="NO_ENGINE_SUBSTITUTION" and skip-innodb
in the MySQL configuration file (my.cnf), i.e. InnoDB is disabled and an attempt
to use InnoDB will result in an error message, MediaWiki's desire to use InnoDB
tables will fail during installation:

 *  Creating tables... using MySQL 3/4 table defs...Query "CREATE
    TABLE mw_user ( user_id int(5) unsigned NOT NULL auto_increment,
    user_name varchar(255) binary NOT NULL default '', user_real_name
    varchar(255) binary NOT NULL default '', user_password tinyblob
    NOT NULL default '', user_newpassword tinyblob NOT NULL default
    '', user_email tinytext NOT NULL default '', user_options blob
    NOT NULL default '', user_touched char(14) binary NOT NULL
    default '', user_token char(32) binary NOT NULL default '',
    user_email_authenticated CHAR(14) BINARY, user_email_token
    CHAR(32) BINARY, user_email_token_expires CHAR(14) BINARY,
    PRIMARY KEY user_id (user_id), UNIQUE INDEX user_name
    (user_name), INDEX (user_email_token) ) TYPE=InnoDB" failed with
    error code "The 'InnoDB' feature is disabled; you need MySQL
    built with 'InnoDB' to have it working".

My suggestion would be that MediaWiki should check whether InnoDB is available
(SHOW VARIABLES LIKE 'have_innodb'; should not return DISABLED) and/or the SQL
mode (SHOW VARIABLES LIKE 'sql_mode'; should not contain
NO_ENGINE_SUBSTITUTION), and possibly attempt to set its preference using
dynamic system variables for the session (SET SESSION table_type='InnoDB';), see
http://dev.mysql.com/doc/refman/5.0/en/using-system-variables.html, instead of
always specifying TYPE=InnoDB in its SQL scripts.

Best regards,
Björn
Comment 1 Rob Church 2007-04-11 00:37:18 UTC
MediaWiki relies upon being able to use InnoDB for all the major tables (page,
revision, and text at least need decent transaction support), decent length
indexes and table space.

We're not going to stop specifying a storage engine when we want to use it.
Comment 2 River Tarnell 2007-04-11 00:38:52 UTC
with the forthcoming Falcon storage engine it might make sense to have this be less static; but i don't think 
MyISAM will ever work well.
Comment 3 Brion Vibber 2007-04-24 13:56:37 UTC
Should check whether the new installer code in 1.10 resolves this issue.
Comment 4 Chad H. 2009-07-25 13:37:37 UTC
Should be fixed with r52672, we now check to make sure the engines are enabled.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links