Last modified: 2014-01-12 13:29:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52805, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50805 - Search suggestions box is misaligned in Konqueror 4.8.5
Search suggestions box is misaligned in Konqueror 4.8.5
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.22.0
All All
: Low minor (vote)
: 1.23.0 release
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-05 14:45 UTC by Chris McKenna
Modified: 2014-01-12 13:29 UTC (History)
5 users (show)

See Also:
Web browser: Other
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chris McKenna 2013-07-05 14:45:55 UTC
See https://commons.wikimedia.org/wiki/File:Knoq_search_monobook_and_vector.png

When using Koqueror 4.8.5 and entering any search term in the search box, the suggestions list always appears in the top left corner of the window/tab. 

This seems independent of skin, wiki, and logged in/out status. Screenshots show monobook when logged in to en.wikipedia and vector when logged out of de.wikisource

This does not happen in Firefox 22, which is the only other graphical browser I have access to. I don't know how long this has been the case as Firefox is my normal browser and I was only using Konqueror to test a visual editor-related bug.
Comment 1 Chris McKenna 2013-07-05 14:46:41 UTC
Oops, should have added that my system is Xubuntu Linux 12.04 LTS.
Comment 2 Andre Klapper 2013-07-08 09:55:30 UTC
Thanks for taking the time to report this!

Confirming problem in Konqueror 4.10.4.

I guess this is another incarnation of bug 45668, do you agree?
Comment 3 Chris McKenna 2013-07-08 12:02:45 UTC
It might be related to that bug, but I don't have anywhere near the knowledge required to say. Sorry.
Comment 4 Bartosz Dziewoński 2013-07-10 13:19:40 UTC
It doesn't seem like bug 45668, that one was browser-independent. This one looks like a KHTML bug.

I don't have a Konqueror to test, but looking at the screenshots I suspect that jQuery's .offset() function is returning zeroes instead of real values. (Left position of the suggestions is zero, while top position appears to take into account the height of the search box, but not it's position.)
Comment 5 Bartosz Dziewoński 2013-07-10 16:33:09 UTC
I actually installed Konqueror on my Windows XP just to test this.

Try it out at: http://www.quirksmode.org/dom/tests/rectangles.html

Konqueror simply doesn't support getting the position of an element. I'm pretty sure it's not possible to implement the same functionality for it.
Comment 6 Gerrit Notification Bot 2013-11-17 16:39:22 UTC
Change 95871 had a related patch set uploaded by Bartosz Dziewoński:
mediawiki.searchSuggest: Blacklist Konqueror

https://gerrit.wikimedia.org/r/95871
Comment 7 Andre Klapper 2013-11-17 17:29:13 UTC
Note: I cannot reproduce this problem in Konqueror 4.11.3 anymore. 
It does not look awesome, but apart from being a few pixels off it's more or less in the correct place (below the search text input field on mediawiki.org).

As written in comment 2, this was still an issue in Konqueror 4.10.4.
Comment 8 Bartosz Dziewoński 2013-11-17 23:56:17 UTC
Huh. Thanks for that, Andre, I updated the patch to only blacklist Konquerors older than 4.11.

I'd appreciate if you could test it, because I've been unable to get Ubuntu 12 to install a Konqueror newer than 4.8, and I've downloaded enough VMs for today.
(I did verify that 4.8 gets blacklisted.)
Comment 9 Andre Klapper 2013-12-18 14:41:49 UTC
MatmaRex: Not sure how to quickly test this, sorry... :-(
Comment 10 Bartosz Dziewoński 2013-12-18 15:12:03 UTC
* Install a MediaWiki
* Apply or checkout that patch
* Verify that no search suggestions appear when you type in the search field
  on Konqueror < 4.11 (make sure your wiki has some pages first)
* Verify that search suggestions do appear on Konqueror >= 4.11 and
  other browsers and are correctly placed near the search field

:)
Comment 11 Gerrit Notification Bot 2014-01-12 13:22:32 UTC
Change 95871 merged by TheDJ:
mediawiki.searchSuggest: Blacklist Konqueror < 4.11

https://gerrit.wikimedia.org/r/95871

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links