Last modified: 2010-01-15 23:36:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 5061 - Thumbnail styles in main.css and commonprint.css are too imprecise
Thumbnail styles in main.css and commonprint.css are too imprecise
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy, patch, patch-need-review
Depends on:
Blocks: css
  Show dependency treegraph
 
Reported: 2006-02-22 07:58 UTC by Zoran Obradovic
Modified: 2010-01-15 23:36 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Use div.thumbinner (1.13 KB, patch)
2009-08-07 13:43 UTC, Derk-Jan Hartman
Details
same patch, but for commonPrint.css (628 bytes, patch)
2010-01-15 15:25 UTC, Derk-Jan Hartman
Details

Description Zoran Obradovic 2006-02-22 07:58:33 UTC
Main.css contains some imprecise definitions that screw up attempts to have divs
inside the image caption, and, are just badly coded. The first four definitions
under /*thumbnails*/ should be replaced with the following more precise code
which gives the same visual results:

/* thumbnails */
div.thumb {
	border-style: solid;
	border-color: white;
	width: auto;
	margin-bottom: .5em;
}
div.thumb > div {
	border: 1px solid #ccc;
	background-color: #f9f9f9;
	text-align: center;
	overflow: hidden;
        padding:3px;
}
div.thumb > div > a img {
	border: 1px solid #ccc;
}
div.thumbcaption {
	font-size: 88%;
	text-align: left;
	line-height: 1.4em;
	padding: .3em .3em .1em .3em;
}
Comment 1 Zoran Obradovic 2006-02-22 08:07:37 UTC
See [[User:Zocky/Sandbox 5]] for an illustration of the problem.
Comment 2 Brion Vibber 2006-02-22 19:26:52 UTC
There's no indication of a problem. The given sample page uses a
huge amount of hardcoded styles for no apparent reason, with no
indication why.

Resolving as INVALID. Reopen with more information if there is actually
some kind of problem.
Comment 3 Zoran Obradovic 2006-02-23 02:48:57 UTC
Basically, we've been trying to make the {{legend}} template work properly
(without inserting characters, and preferably producing properly indented
multi-line labels). The only way to do that in html/css is by using divs, but
all divs inside thumbnail boxes inherit a bunch of formatting which is just
meant for the whole thumbnail box (or rather for its unnamed direct descendent
div, which is the visible gray box), not for each of its subparts. 

Whether styles should be harcoded into templates or put into css files is a
somewhat broader question.
Comment 4 Zoran Obradovic 2006-02-23 05:21:44 UTC
I've added another example at [[User:Zocky/Sandbox 5]] with no hardcoded styles
at all, which exhibits the same problem.
Comment 5 Brion Vibber 2006-02-23 19:15:22 UTC
As I feared; the > child selector doesn't work in IE 6.
Comment 6 Zoran Obradovic 2006-05-09 12:47:30 UTC
Could we name the currently unnamed div around the images and make that style
apply specifically to it, not all div descendants of its parent?
Comment 7 Derk-Jan Hartman 2009-08-07 13:43:13 UTC
Created attachment 6434 [details]
Use div.thumbinner

Easy fix for the chick and simple skins, for a very old bug.
Comment 8 Derk-Jan Hartman 2010-01-15 15:25:17 UTC
Created attachment 6958 [details]
same patch, but for commonPrint.css

The same problem exists for commonPrint.css
Comment 9 Platonides 2010-01-15 23:36:57 UTC
These are the same as r18303 did on monobook.
Applied on r61112. Thanks.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links