Last modified: 2013-08-30 18:51:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52446, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 50446 - VisualEditor: Link inspector in a slug can select content in the previous or following paragraphs
VisualEditor: Link inspector in a slug can select content in the previous or ...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-08-29
Assigned To: Moriel Schottlender
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-06-30 06:15 UTC by James Forrester
Modified: 2013-08-30 18:51 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description James Forrester 2013-06-30 06:15:07 UTC 
If the cursor is in a slug and you press the link button, the selection jumps to the nearest content - which crosses out of the local <p> and into the <p> beforehand or afterwards (whoops).

Link inspector should detect that it is in a slug and not attempt to mangle the selection with nearestContentOffset, but just trigger with a 'blank' selection.
Comment 1 James Forrester 2013-06-30 06:29:24 UTC 
As a follow-up, if you have <start of document> <block slug> <block slug> <block slug> <block slug> <p> in a document, and have the cursor in the second slug, pressing Ctrl+K will move the selection to the top of the document and put the contents there (whee); in the third or fourth, to the first word of the <p>. Not great.
Comment 2 James Forrester 2013-08-30 18:51:09 UTC 
This was fixed by Gerrit change #81437.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links