Last modified: 2013-07-24 02:50:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52385, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50385 - VisualEditor: Categories deleted or misplaced when a reference is added (in Opera)
VisualEditor: Categories deleted or misplaced when a reference is added (in O...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: Low major
: VE-deploy-2013-07-25
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks: 36000
  Show dependency treegraph
 
Reported: 2013-06-28 18:56 UTC by Oliver Keyes
Modified: 2013-07-24 02:50 UTC (History)
7 users (show)

See Also:
Web browser: Other
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Oliver Keyes 2013-06-28 18:56:08 UTC
https://en.wikipedia.org/w/index.php?title=Stand-your-ground_law&diff=562005779&oldid=561464750 is a good example (hat-tip to MatMaRex)
Comment 2 Roan Kattouw 2013-06-29 01:09:29 UTC
Very strange, looks like metadata is being moved somehow. Do we have any information about what the editors did to provoke this?
Comment 3 James Forrester 2013-06-29 02:15:37 UTC
(In reply to comment #1)
> Another is
> https://pl.wikipedia.org/w/index.
> php?title=Waldemar_Kasta&diff=36944980&oldid=36944831

Bartosz,

Both these corruptions were by you - were both of them made using Opera? If so, I'm happy to mark this bug out to you (but please clean up after yourself when editing using a blacklisted browser).
Comment 4 Bartosz Dziewoński 2013-06-29 11:07:34 UTC
Eh, it seems to be Opera-specific after all, I can't reproduce on Firefox (but it reproduces reliably in Opera).
Comment 5 Bartosz Dziewoński 2013-07-05 14:43:55 UTC
Funnily, my testing shows that the categories are only moved inside the reference if it contains a template. Inserting an empty or text-only reference results in the cateogires eing killed entirely.
Comment 6 Bartosz Dziewoński 2013-07-05 19:25:37 UTC
function testSpliceBroken() {
	var n = 256;
	var a = [];
	a[n] = 'a';
	
	a.splice( n+1, 0, 'b' );
	
	return a[n] != 'a';
};

This yields 'true' on Opera.

That's probably the bizarrest browser bug I've ever seen, and it seems to be the root cause of this.
Comment 7 Gerrit Notification Bot 2013-07-05 23:29:36 UTC
Change 72233 had a related patch set uploaded by Matmarex:
Array.prototype.splice polyfill for Opera

https://gerrit.wikimedia.org/r/72233
Comment 8 Gerrit Notification Bot 2013-07-22 18:40:03 UTC
Change 72233 merged by jenkins-bot:
Array.prototype.splice polyfill for Opera

https://gerrit.wikimedia.org/r/72233
Comment 9 Bartosz Dziewoński 2013-07-22 19:02:31 UTC
This should be fixed now. Rejoice!
Comment 10 James Forrester 2013-07-24 02:50:50 UTC
Done and will be deployed tomorrow.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links