Last modified: 2013-07-17 14:32:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52371, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50371 - WikibaseDataModel issues from outage
WikibaseDataModel issues from outage
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: Highest critical (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-28 12:00 UTC by Sam Reed (reedy)
Modified: 2013-07-17 14:32 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2013-06-28 12:00:01 UTC
From Tims post mortem of the outage overnight:

"WikibaseDataModel returns null from the file level of its extension setup file, causing mergeMessageFileList.php to abort even when the file was present."

Not sure if any other of your extensions are potentially vulnerable due to similar loader code setups

See also 50347
Comment 1 Aude 2013-06-28 12:08:23 UTC
attempt to make localisation update happier:

https://gerrit.wikimedia.org/r/#/c/71004/

although think there are underlying issues with the way WikibaseDataModel is loaded and also issues with the mergeMessageFileList.php script.
Comment 2 Aude 2013-06-28 12:21:18 UTC
probably related to this code in WikibaseDataModel and bad interaction with the version of Wikibase in wmf8.

if ( defined( 'WIKIBASE_DATAMODEL_VERSION' ) ) {                                                    
    // Do not initialize more then once.                                                            
    return;                                                                                         
} 

having WikibaseDataModel and Wikibase/DataModel (in the wmf8 version of Wikibase) means that the constant WIKIBASE_DATA_MODEL gets set already before WikibaseDataModel is loaded.

not having WikibaseDataModel there means mergeMessageFileList chokes

can't mergeMessageFileList check if the file exists and if not, skip it?
Comment 3 Aude 2013-07-03 12:34:53 UTC
https://gerrit.wikimedia.org/r/#/c/71056/ to provide a --force option in the mergeMessageFileList script to be able to ignore any missing extensions.

By default, it will still abort and then require the script operator to look at the situation.  If something like WikibaseDataModel, then --force can be used, since that component was already present in Wikibase in the wmf8 version.
Comment 4 Aude 2013-07-03 12:35:51 UTC
In the future, we could have a different version constant name when we move a component out of an existing deployed extension.  That way, localisation update could load it.
Comment 5 Daniel Kinzler 2013-07-17 11:33:08 UTC
Closing. There is nothing we can do right now, except to be aware of the issue next time.
Comment 6 abraham.taherivand 2013-07-17 14:32:15 UTC
Verified in Wikidata demo time July 17th

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links