Last modified: 2010-05-15 15:33:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 502 - Bad title error condition produces some silly links
Bad title error condition produces some silly links
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.4.x
All All
: Low minor with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/wiki/%3Cbad%3E
: patch, patch-need-review
: 852 1341 3970 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-09-15 22:11 UTC by Brion Vibber
Modified: 2010-05-15 15:33 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch to set $wgTitle to "Special:Badtitle" instead of "Bad title" when a bad title is encountered (1.01 KB, patch)
2006-07-01 16:47 UTC, Ilmari Karonen
Details

Description Brion Vibber 2004-09-15 22:11:32 UTC
If you try to go to a bad title, the error message shows on a pseudo-page titled "Bad title". This includes showing talk page, edit, 
watch and undelete links for "[[Bad title]]"!

Perhaps bad title & similar errors need to work on a hidden [[Special:Error]], like the search now does.
Comment 1 Antoine "hashar" Musso (WMF) 2004-09-17 16:32:23 UTC
Fixed in cvs, error pages stop showing the quickbar.
Comment 2 Brion Vibber 2004-11-10 06:38:53 UTC
*** Bug 852 has been marked as a duplicate of this bug. ***
Comment 3 Brion Vibber 2004-12-04 03:46:59 UTC
(In reply to comment #1)
> Fixed in cvs, error pages stop showing the quickbar.

r1=1.109&r2=1.110">http://cvs.sourceforge.net/viewcvs.py/wikipedia/phase3/includes/SkinPHPTal.php?r1=1.109&r2=1.110

This change caused a very ugly regression: the tabs are all missing in diff page views except a bogus 
"special page" tab (bug 987). The 'quickbar' is the *sidebar*; under some of the older skins the diff view 
turned off the sidebar in order to maximize the horizontal space available to show side-by-side diffs. 
MonoBook isn't really set up to make disabling the sidebar possible, so it was just ignored.

Quickbar suppression doesn't seem to be the right trigger here.
Comment 4 Brion Vibber 2004-12-04 05:12:14 UTC
In addition to breaking diff pages in MonoBook, the co-opting of quickbar 
suppression also makes error pages look really weird in the Classic skin. 
I've removed the broken fix.
Comment 5 Brion Vibber 2005-01-16 08:25:17 UTC
*** Bug 1341 has been marked as a duplicate of this bug. ***
Comment 6 Brion Vibber 2005-11-16 22:51:19 UTC
*** Bug 3970 has been marked as a duplicate of this bug. ***
Comment 7 lɛʁi לערי ריינהארט 2006-01-17 09:39:44 UTC
Another error condition is handeled at

Bug 4638: Error condition generates wrong tabs links pointing to {{PAGENAME}} in
the main namespace and not to {{FULLPAGENAME}}

best regards reinhardt [[user:gangleri]]
Comment 8 Sam Horn 2006-05-06 08:55:59 UTC
Couldn't this problem be fixed by changing [[MediaWiki:Badtitle]]? I'm not sure
what it would break, but it seems to work at a wiki I tested it on. (See
http://fanstuff.hrwiki.org/index.php/MediaWiki:Badtitle and
http://fanstuff.hrwiki.org/index.php/|)
Comment 9 Ilmari Karonen 2006-07-01 16:47:04 UTC
Created attachment 2034 [details]
Patch to set $wgTitle to "Special:Badtitle" instead of "Bad title" when a bad title is encountered

This simple change seems to fix it.  I've tested it locally and found no
breakage, though I'd naturally welcome additional testing.

There is, of course, no Special:Badtitle; this doesn't really matter, the point
is just to set $wgTitle to any title in NS_SPECIAL.  In fact, it's probably
better for it to be a nonexistent page, just in case any skin tries to link
back to it.

Non-monobook skins, in fact, apparently do just that, through a "Printable
version" link; I'm not sure if that should be considered a bug in those skins. 
Monobook doesn't provide such a link for special pages at all, although it does
provide a "Special page" tab linking back to the original bad title (*not* to
Special:Badtitle).  In either case, any user that happens to click such a link
is merely confronted with a second, rather self-explanatory error page.
Comment 10 Brion Vibber 2006-07-01 17:09:04 UTC
Applied as r15203

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links