Last modified: 2006-04-27 21:20:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T7005, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 5005 - <gallery> produces a </tr> without a matching <tr>
<gallery> produces a </tr> without a matching <tr>
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.6.x
All All
: Normal minor with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2006-02-16 00:04 UTC by Jitse Niesen
Modified: 2006-04-27 21:20 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
bug fix (613 bytes, patch)
2006-02-16 00:05 UTC, Jitse Niesen 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Jitse Niesen 2006-02-16 00:04:47 UTC 
The following wikitext
----
<gallery>
a
</gallery>
----
produces this HTML (attributes omitted for clarity):
----
<table><td><div>A</div></td></tr>
</table>
----
This is usually cleaned up by HTML Tidy.

Note that there is no <tr> tag, but there is a </tr> tag.
The attached patch fixes this.

Additionally, I get the error message:
"Only variables should be assigned by reference in
/home/jitse/wikipedia/phase3-cvs/includes/Parser.php on line 3678

I didn't fix this as it might indicate some deeper bug.
Comment 1 Jitse Niesen 2006-02-16 00:05:36 UTC 
Created attachment 1392 [details]
bug fix
Comment 2 Antoine "hashar" Musso (WMF) 2006-04-27 21:20:11 UTC 
Fixed in trunk@13890 , REL1_6@13891 . Will be in 1.6.4 .

Thanks for the patch!
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links