Last modified: 2014-03-20 18:04:15 UTC
This is fairly important to get fixed up. https://en.wikipedia.org/w/index.php?title=User_talk:Simsong&diff=560107518&oldid=418874412 Currently PageCuration isn't including a timestamp in its posts. This is problematic, as talk page archive bots often rely on a timestamp in a section to determine which sections to automatically archive. Without a standard timestamp, these sections can become zombies, stuck in talk page purgatory indefinitely. It may make sense to fix this locally as soon as possible (assuming the relevant MediaWiki page can be edited to include "~~~~~"). But a general fix to this issue in the extension itself is needed in fairly short order.
Related URL: https://gerrit.wikimedia.org/r/68942 (Gerrit Change Icf5f7f7e813f6b4ba58c9ea8b5a79e9420198b61)
Strange. I wonder why bug 46842 didn't resolve this. If there are multiple places where this same code is needed, putting it in a variable or wrapper function may make sense.
(In reply to comment #2) > Strange. I wonder why bug 46842 didn't resolve this. We are all humans and sometimes forget all the different places we need to fix :) > If there are multiple places where this same code is needed, putting it in a > variable or wrapper function may make sense. Sorry, but I find this as a totally unacceptable solution for the current problem. Besides I welcome you to try that out if you please. Thank God, its open source!
(In reply to comment #3) > (In reply to comment #2) >> Strange. I wonder why bug 46842 didn't resolve this. > > We are all humans and sometimes forget all the different places we need to > fix :) Right, which is why I suggested de-duplicating the code by using a variable or wrapper function.
(In reply to comment #4) > Right, which is why I suggested de-duplicating the code by using a variable > or > wrapper function. Say, I have a wrapper function called addSignature (This is the only part where the same code is being used), then I would again have to call this method from all the places. I could still forget adding that.
This bug wasn't caused by a programming error, rather it is due to bad design. Two of the PageTriage templates on enwiki, "Reviewednote-NPF" and "Unreviewednote-NPF", are not written from the point of view of the reviewer, so it doesn't make sense to sign them. There are two ways to fix the problem: 1. Change the code in ext.pageTriage.mark.js so that it adds a sig to those templates. When the new code is deployed, rewrite the templates from a first person perspective (similar to the other PageTriage templates). or 2. Change the code in ext.pageTriage.mark.js so that it adds just a timestamp to those templates ('~~~~~'). Not sure if this fixes the zombie problem or not.
I think (?) this has been fixed? I haven't seen this problem appearing.
