Last modified: 2014-03-01 00:13:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51617, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49617 - VisualEditor: Visually discourage use of "legal" but unwanted structures in sub-editors (e.g. lists in references)
VisualEditor: Visually discourage use of "legal" but unwanted structures in s...
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal enhancement
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-15 12:01 UTC by This, that and the other (TTO)
Modified: 2014-03-01 00:13 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description This, that and the other (TTO) 2013-06-15 12:01:41 UTC
In VE, click the "Reference" toolbar icon. According to the toolbar icons in the "Content" section, it is possible to insert lists, headings and images within the text of a reference.

This is a nonsensical capability. The only required formatting here is bold, italic and wikilink, if that.
Comment 1 This, that and the other (TTO) 2013-06-15 12:02:56 UTC
(In reply to comment #0)
> lists, headings and images

Sorry, the list functionality has been correctly removed from this view. It is only headings and images that need to be hidden.
Comment 2 James Forrester 2013-06-16 22:41:08 UTC
(In reply to comment #1)
> (In reply to comment #0)
> > lists, headings and images
> 
> Sorry, the list functionality has been correctly removed from this view. It
> is only headings and images that need to be hidden.


Regrettably, wikitext does actually pretty much everything inside references except other references (though some, ahem, "enterprising" users have found a way around that intentional limit). Examples:

  https://www.mediawiki.org/wiki/VisualEditor:TestReferenceContents

Maybe we can discourage users from doing these things in some way, but we can't just not support this, as users have to be able to edit these back into a more rational use.

(The reason that these were removed are that you're not allowed lists in image captions; we're clearly going to have to split what things the sub-editors can allow by type. Created that as bug 49657.)
Comment 3 This, that and the other (TTO) 2013-06-16 23:50:45 UTC
(In reply to comment #2)
> Maybe we can discourage users from doing these things in some way, but we
> can't
> just not support this, as users have to be able to edit these back into a
> more
> rational use.

On enwiki there is never any good reason to have headings or images in references. In the 0.000001% of cases where it is actually wanted, it can just be done using the wikitext source editor, I think.

However, I can understand that other wikis might want this functionality in VE for some reason, so I suppose enwiki could hide the relevant functionality via CSS or something like that if you think it would be better.
Comment 4 James Forrester 2013-06-17 00:34:22 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > Maybe we can discourage users from doing these things in some way, but we
> > can't
> > just not support this, as users have to be able to edit these back into a
> > more
> > rational use.
> 
> On enwiki there is never any good reason to have headings or images in
> references. In the 0.000001% of cases where it is actually wanted, it can
> just be done using the wikitext source editor, I think.

The objective of VE is for even power users to never need to enter the wikitext editor. Fixing broken usage would be an example of a use case that we'd want to support.

> However, I can understand that other wikis might want this functionality in
> VE for some reason, so I suppose enwiki could hide the relevant functionality
> via CSS or something like that if you think it would be better.

I was thinking of having such tools hidden under an "advanced tools" collapsed block in the toolbar, but we should properly look at this rather than just commit to the way to do it in a Bugzilla thread. :-) Ideally we'd rather not have individual wikis trying to come up with local-only "solutions" to this.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links