Last modified: 2006-05-31 01:10:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 4940 - Uninitialized local variables
Uninitialized local variables
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.6.x
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-02-09 23:06 UTC by Michael Keppler
Modified: 2006-05-31 01:10 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Michael Keppler 2006-02-09 23:06:45 UTC
The following local variables are not initialized anywhere. Please note that
this is not an unfiltered list of potentially undefined variables, but those are
the 3 remaining items from a list of 71 potential items reported by PHPeclipse,
which I checked for includes, loops, extract() or other specialities, so I'm
certainly sure, they are not initialized.

Skin.php, doGetUserStyles(), $action, line 321 (missing global?)
SpecialNewPages.php, feedItemDesc(), $text, line 101 (completely unused?)
SquidUpdate.php, purge(), $s, line 147 (copy paste error from below, where $s is
defined?)
Comment 1 Antoine "hashar" Musso (WMF) 2006-04-24 15:56:57 UTC
Added @todo for Skin.php $action.
Fixed SquidUpdate.php $s , that caused socket to always be blocking.

I havent found the other issues in the code.
Comment 2 Rob Church 2006-05-31 01:10:03 UTC
Fixed the issue in Skin.php in SVN trunk, r14489. Can't find the reference to
$text in SpecialNewpages.php where cited, so I think we can assume this was
fixed another time.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links