Last modified: 2013-06-28 00:37:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51307, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 49307 - VisualEditor: Copy & paste should use ve.dm.Node#getClonedElement
VisualEditor: Copy & paste should use ve.dm.Node#getClonedElement
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-07-04
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-06-07 13:43 UTC by Ed Sanders
Modified: 2013-06-28 00:37 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ed Sanders 2013-06-07 13:43:00 UTC 
Because we want to be able to make certain properties non-cloneable, e.g. in ve.dm.MWReferenceNode.prototype.getClonedElement we strip 'contentsUsed'.
Comment 1 Gerrit Notification Bot 2013-06-27 20:30:26 UTC 
Change 70913 had a related patch set uploaded by Catrope:
Invoke getClonedElement() on each element on copy

https://gerrit.wikimedia.org/r/70913
Comment 2 Ed Sanders 2013-06-27 20:59:07 UTC 
We should very that copy/pasting a named reference with contents, doesn't copy the contents.
Comment 3 Ed Sanders 2013-06-27 21:00:01 UTC 
"We should verify..."
Comment 4 Gerrit Notification Bot 2013-06-27 22:31:41 UTC 
Change 70913 merged by jenkins-bot:
Invoke getClonedElement() on each element on copy

https://gerrit.wikimedia.org/r/70913
Comment 5 James Forrester 2013-06-28 00:37:36 UTC 
Fixed and will go live in a few minutes.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links