Last modified: 2013-06-20 22:14:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51275, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49275 - VisualEditor: Phantoms appear above the save dialog, preventing saving
VisualEditor: Phantoms appear above the save dialog, preventing saving
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-06-20
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-06 21:25 UTC by Steven Walling
Modified: 2013-06-20 22:14 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot (204.97 KB, image/png)
2013-06-06 21:25 UTC, Steven Walling
Details

Description Steven Walling 2013-06-06 21:25:46 UTC
Created attachment 12483 [details]
Screenshot

In attempting to test (as anon) on the MediaWiki.org sandbox, the page header template overlaps the diff and save functions, preventing me from saving my edit.
Comment 1 James Forrester 2013-06-06 21:38:30 UTC
Whoops, thanks for the spot, Steven!
Comment 2 Mark Hurd 2013-06-09 11:18:21 UTC
And I had a similar issue attempting to save a page with an (uneditable) InfoBox on the right hand side. Luckily a simple workaround for the moment is to scroll down!

Obviously the proper solution is to ensure the zorder of the "Review your changes" and "Save your changes"/"Report a problem" is above the "phantoms".
Comment 3 Krinkle 2013-06-10 07:54:07 UTC
Instead of an arms race between z-index, the much easier solution would be to ensure the DOM structure of these two elements are nested properly so that their natural order is correct. z-index can be used to adjust display, but it is not capable (by design) to transcend the relative DOM position.

I haven't tested the following so this exact example could be wrong, but generally it means that in the following sample:

 <div style="position: relative;" id="foo"> </div> 
 <div style="position: relative;" id="bar"> </div> 


Naturally #bar will be on top of #foo as it comes later in the DOM. Though #foo and #bar can be interchanged at the root (through their common parent), any child of #bar will always be on top of any child of #foo.

So not only is DOM ordering easier to manage (due to not having to worry about conflicting numbers), in some cases it is the only way.

I'll see what the easier way to fix this is, we can perfect it later if suboptimal.
Comment 4 Guillaume Paumier 2013-06-19 14:33:38 UTC
Just a note that this also happens with editable elements like images, as their blue overlay extends on top of the VE menu bar.
Comment 5 Gerrit Notification Bot 2013-06-20 00:37:07 UTC
Related URL: https://gerrit.wikimedia.org/r/69614 (Gerrit Change I2fbc4c8af943f1b096b8912191924961405d5c47)
Comment 6 James Forrester 2013-06-20 22:14:25 UTC
Merged and will go out later today.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links