Last modified: 2007-09-20 19:55:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 4918 - User preference for no email notification for minor edits does not work
User preference for no email notification for minor edits does not work
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User preferences (Other open bugs)
1.6.x
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Scott A. Colcord
: easy, patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-02-08 14:37 UTC by David Biesack
Modified: 2007-09-20 19:55 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch as described in prior comments (897 bytes, patch)
2007-08-19 17:40 UTC, Scott A. Colcord
Details

Description David Biesack 2006-02-08 14:37:09 UTC
We've enabled email notification on our intranet wiki. In my preferences, I have
"Send me an email also for minor edits of pages" disabled but our MediaWiki
1.5.6 system is still sending me email when someone makes a minor edit. The page
history shows the edit is a minor edit and the email contains

  Editor's summary: (comment...)  This is a minor edit

UserMailer.php contains
    ...
    && (!$minorEdit || ($wgEnotifMinorEdits &&
$watchingUser->getOption('enotifminoredits') ) )

which looks correct.

I can add 

   $wgEnotifMinorEdits = false; # UPO; false: "minor edits" on pages do not
trigger notification mails.

to LocalSettings.php but I'd rather give users the option to set this themselves.

I'm using the standard MW 1.5.6; I did not download/install ENotif separately.
Comment 1 T. Gries 2006-02-08 19:54:57 UTC
The logical expression in MediaWiki is incorrect, you need to add a pair of
parentheses marked as ***(*** and ***)***

MediaWiki ( 2 parentheses missing)
http://cvs.sourceforge.net/viewcvs.py/wikipedia/phase3/includes/UserMailer.php?annotate=1.38
:

if ***(*** ( ( $enotifwatchlistpage &&
$watchingUser->getOption('enotifwatchlistpages') ) ||
 	  	  	  ( $enotifusertalkpage &&
$watchingUser->getOption('enotifusertalkpages') ) ***)***
 	  	  	  && (!$minorEdit || ($wgEnotifMinorEdits &&
$watchingUser->getOption('enotifminoredits') ) )
 	  	  	  && ($watchingUser->isEmailConfirmed() ) ) {


See also EnotifWiki
http://cvs.berlios.de/cgi-bin/viewcvs.cgi/enotifwiki/enotifwiki/includes/UserMailer.php?annotate=1.10
for the correct part.
Comment 2 T. Gries 2006-02-08 19:57:23 UTC
a regular patch will not follow, because this is a trivial change.
Comment 3 Brion Vibber 2006-02-08 22:39:10 UTC
Please test 1.6 from CVS HEAD; 1.5 is old and lots of email notification bits are broken in it.
Comment 4 T. Gries 2006-02-08 22:53:24 UTC
(In reply to comment #3)
> Please test 1.6 from CVS HEAD; 1.5 is old and lots of email notification bits
are broken in it.


Brion, the small amendment is also needed in your MediaWiki HEAD, where I took
the code sniplet from.
Comment 5 Scott A. Colcord 2007-08-19 17:27:59 UTC
Pinging the radar on this; it's a trivial fix for an obvious bug, with a patch provided and review requested, and no action on it for over a year.
Comment 6 Rob Church 2007-08-19 17:33:29 UTC
Need an actual patch file; patches in comments of this nature are a bit awkward to review.
Comment 7 Scott A. Colcord 2007-08-19 17:40:27 UTC
Created attachment 4012 [details]
Patch as described in prior comments
Comment 8 Brion Vibber 2007-09-20 19:55:58 UTC
Applied w/ formatting adjustments in r25974, but I can't actually reproduce the bug.

I seem to get the expected behavior both with and without the patch.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links