Last modified: 2014-05-30 20:59:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51044, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49044 - VisualEditor: Category editor should also suggest categories which 'exist' but are without a description page
VisualEditor: Category editor should also suggest categories which 'exist' bu...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Low normal
: VE-deploy-2014-05-29
Assigned To: Alex Monk
:
: 65956 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-01 18:57 UTC by Krinkle
Modified: 2014-05-30 20:59 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2013-06-01 18:57:19 UTC
Users and categories should not be auto-completed based on page names (API action=opensearch) but instead based on their own respective query modules (list=allusers, list=allcategories) because the existence of a description page is optional and neither a subset nor superset of the database tables.

* Pages can exist for inexistent objects.
* Objects often don't have an associated page.

718db58f introduced category editing with autocompletion from opensearch (with hardcoded 'Category:' prefix). This should be switched to using list=allcategories instead.

That way the input field will no longer include results for inexistent categories, and no longer omit results for existing categories lacking a description page.
Comment 1 Derk-Jan Hartman 2013-06-04 19:02:03 UTC
Though I commend the effort for correctness, I don't think that this has ever even been brought up in the HotCat feedback. It would be nice though.

However, an empty category (page only), is still a valid category in most workflows (you have to start somewhere), so I think that excluding them is no more correct than including categories without pages...
Comment 2 Krinkle 2013-06-24 19:37:54 UTC
(In reply to comment #1)
> Though I commend the effort for correctness, I don't think that this has ever
> even been brought up in the HotCat feedback. It would be nice though.
> 
> However, an empty category (page only), is still a valid category in most
> workflows (you have to start somewhere), so I think that excluding them is no
> more correct than including categories without pages...

(Whilst not defending the current MediaWiki behaviour) the way you start a new category is either:
* Create the description page
* Add pages to it from wikitext with [[Category: <name> ]]
or:
* Implicitly create it by adding pages to it from wikitext with [[Category: <name> ]]

The same is true for HotCat, afaik you can use a category that doesn't exist yet. The page is optional and the 'Category' table row will be created once there are items in it (though it doesn't delete the row if there are no more children in it, so you can still have category pages for categories that don't "exist" but do exist in the database).

Either way I think it is more likely for a user to want to add a page to a category that is used on another page (which may or may not have a description page yet) then for a user to first create a category page and then add a page to it. Especially on established wikis.

I agree it doesn't really make sense but this is how MediaWiki works. We could change MediaWiki core to also create category rows immediately when the page is created.

We could do 2 ajax requests for every autocomplete action but that seems a bit too much, and given the choice between the two I think completing based on existing categories instead of category description pages, the former is more likely and also has larger volume (there are more categories than there are description pages, there are relatively few category pages for categories that don't exist, ideally a wiki would have none of them).
Comment 3 Gerrit Notification Bot 2014-05-28 16:37:44 UTC
Change 135782 had a related patch set uploaded by Alex Monk:
Suggest categories that exist but don't necessarily have pages

https://gerrit.wikimedia.org/r/135782
Comment 4 Gerrit Notification Bot 2014-05-29 00:06:29 UTC
Change 135782 merged by jenkins-bot:
Suggest categories that exist but don't necessarily have pages

https://gerrit.wikimedia.org/r/135782
Comment 5 James Forrester 2014-05-30 20:59:40 UTC
*** Bug 65956 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links