Last modified: 2013-05-23 09:13:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50734, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48734 - VisualEditor: Toolbar should clear float to avoid misalignment by extra elements
VisualEditor: Toolbar should clear float to avoid misalignment by extra elements
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2013-05-27
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-22 23:04 UTC by Krinkle
Modified: 2013-05-23 09:13 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
What the toolbar usually looks like (965.57 KB, image/png)
2013-05-22 23:05 UTC, Krinkle
Details
Current misalignment when there are extra elements in #content (962.31 KB, image/png)
2013-05-22 23:06 UTC, Krinkle
Details
What it looks like with clear:both patch applied (955.29 KB, image/png)
2013-05-22 23:06 UTC, Krinkle
Details

Description Krinkle 2013-05-22 23:04:38 UTC
On wikis where certain "topicons" are moved out of the mw-content-text wrapper into the root of #content the VisualEditor toolbar shows a weird blank space.

The icons in question are invisible due to float overlap, but they do push down the toolbar and occupying space to the right of the "Save and review" button thus pushing it and the rest of ve-ui-toolbar-actions to the left.

To reproduce this situation, run the following one or more times:

    $('#content').prepend(
        '<div class="mw-topicon" style="display: block; width: 20px; height: 20px; background: pink; float: right; margin-left: 3px;">x</div>'
    );
Comment 1 Krinkle 2013-05-22 23:05:25 UTC
Created attachment 12373 [details]
What the toolbar usually looks like

Note absence of space between the Vector tabs and the toolbar, and the Save button is flush to the right.
Comment 2 Krinkle 2013-05-22 23:06:03 UTC
Created attachment 12374 [details]
Current misalignment when there are extra elements in #content

Such as the case currently on https://de.wikipedia.org/wiki/Berlin
Comment 3 Krinkle 2013-05-22 23:06:56 UTC
Created attachment 12375 [details]
What it looks like with clear:both patch applied

The icons become visible again and the actions toolbar (right hand side of the toolbar) is no longer pushed to the left but flush to the right again.
Comment 4 Gerrit Notification Bot 2013-05-22 23:08:00 UTC
Related URL: https://gerrit.wikimedia.org/r/64989 (Gerrit Change Ic5f73ac1eb8c41b891dd1c67b71795cb6c456141)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links