Last modified: 2014-06-05 10:12:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50731, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 48731 - Special:RecentChanges shouldn't show "rollback" for namespaces the user can't edit


Summary:	Special:RecentChanges shouldn't show "rollback" for namespaces the user can't...

Status:	NEW

Product:	MediaWiki
Classification:	Unclassified
Component:	Recent changes (Other open bugs)
Version:	1.22.0
Hardware:	All All

Importance:	Low normal (vote)
Target Milestone:	---
Assigned To:	Tyler Romeo

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-05-22 21:13 UTC by Meno25
Modified:	2014-06-05 10:12 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Screenshot (272.44 KB, image/png) 2013-05-29 03:08 UTC, Meno25	Details
Add an attachment (proposed patch, testcase, etc.)

Description Meno25 2013-05-22 21:13:20 UTC

To reproduce:

1-Login using an account that has rollback rights but not admin rights.

2-View [[Special:RecentChanges]] in MediaWiki namespace.

Current result:

There is a "rollback" link after the name of each Mediawiki page. Clicking that link gives an error: "You do not have permission to quickly rollback the edits of the last user who edited a particular page... etc"

Expected result:

This shouldn't be links to rollback MediaWiki pages in recent changes for non-admin users because they can't edit pages in MediaWiki namespace.


This bug was encountered on arwiki.

MediaWiki    1.22wmf4 (281e88a)
PHP          5.3.10-1ubuntu3.6+wmf1 (apache2handler)
MySQL	     5.1.53-wm-log
LuaSandbox   1.6-1
Lua          5.1.4

Comment 1 Tyler Romeo 2013-05-29 02:04:34 UTC

I cannot seem to replicate this issue. Is anybody else experiencing this?

Comment 2 Meno25 2013-05-29 03:08:14 UTC

Created attachment 12416 [details]
Screenshot

Notice the blue circle

Comment 3 Alex Monk 2013-05-29 15:30:21 UTC

I couldn't replicate it either.

Comment 4 Meno25 2013-05-29 19:49:43 UTC

(In reply to comment #3)
> I couldn't replicate it either.

The bug summary is wrong. This happens for pages in MediaWiki namespace only not any page the user can't edit.

Comment 5 Tyler Romeo 2013-05-31 00:34:23 UTC

Realized why I couldn't replicate: forgot to give my user rollback permissions. ;)

Will have a patch momentarily.

Comment 6 Gerrit Notification Bot 2013-05-31 00:36:10 UTC

Related URL: https://gerrit.wikimedia.org/r/66191 (Gerrit Change I3a037af5839b20d1161dcfbb5329df1e9f2989ec)

Comment 7 Gerrit Notification Bot 2014-01-03 10:53:10 UTC

Change 66191 abandoned by Parent5446:
Fixed permissions check for showing rollback link in RC

Reason:
Doesn't seem to be a way to fix this.

https://gerrit.wikimedia.org/r/66191

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links