Last modified: 2013-06-13 10:14:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50671, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 48671 - <h5> and <h6> have the same font size at default settings in some skins
<h5> and <h6> have the same font size at default settings in some skins
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.22.0
All All
: Low minor (vote)
: 1.22.0 release
Assigned To: Bartosz Dziewoński
: easy
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-05-21 06:45 UTC by entlinkt
Modified: 2013-06-13 10:14 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Proposed fix: Enlarge <h5> to 108% in Vector and Monobook (224 bytes, patch)
2013-05-30 00:01 UTC, entlinkt 		Details
Add an attachment (proposed patch, testcase, etc.)

Description entlinkt 2013-05-21 06:45:27 UTC 
Browsers tend to have a default font size of 16px and the Vector and Monobook skins use various techniques to end up at 12.8px resp. 12.7px for the bodytext.

Now, in commonElements.css, we have 105% for <h5> and 100% for <h6>. This gives rounded values of 13px for <h5> and <h6> in Vector and Monobook, making them hard to distinguish. (To avoid this, 108% has been used at dewiki for several years.)

Modern is not affected by this problem because it uses browser default font sizes for <hX>. Haven't looked at Cologneblue.
Comment 1 entlinkt 2013-05-22 19:59:55 UTC 
Checked Cologneblue, it OK at the browser default of 16px (h6 ends up at 13.3333px, h5 at 14px and h4 at 14.8px), so only commonElements.css needs to be fixed.
Comment 2 Bartosz Dziewoński 2013-05-29 20:03:14 UTC 
Note that these font-sizes have been changed quite recently in I45bf6e8c (previously they were smaller than body text, which was a little silly). Are you sure 108% was being used? (Or were you also adjusting other heading sizes?)

That said, this seems like an easy bug. Maybe you want to try getting [[developer access]] and fixing it yourself? :)
Comment 3 entlinkt 2013-05-30 00:01:24 UTC 
Created attachment 12423 [details]
Proposed fix: Enlarge <h5> to 108% in Vector and Monobook

The remark in comment 0 about the 108% at dewiki is about a local adaption in [[de:MediaWiki:Common.css]] that I'm proposing to get upstream with this report.
Comment 4 Bartosz Dziewoński 2013-06-07 09:58:36 UTC 
Since you apparently don't want to do it yourself ;), I submitted your patch to gerrit (noting you as its author): I9d0fccc6.
Comment 5 Bartosz Dziewoński 2013-06-13 10:11:58 UTC 
The patch has been merged and will be deployed to Wikimedia wikis per [[MediaWiki 1.22/Roadmap|the roadmap]]. Thanks!
Comment 6 Bartosz Dziewoński 2013-06-13 10:14:21 UTC 
[[mw:MediaWiki 1.22/Roadmap]]*
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links