Last modified: 2010-05-15 14:36:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T6838, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 4838 - Patch: relative oldids (prev, next, cur) for raw pages
Patch: relative oldids (prev, next, cur) for raw pages
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-02-02 14:34 UTC by Lupin
Modified: 2010-05-15 14:36 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
proposed patch (1.03 KB, patch)
2006-02-02 14:35 UTC, Lupin
Details
changed direction to diff (1.01 KB, patch)
2006-02-02 18:17 UTC, Lupin
Details

Description Lupin 2006-02-02 14:34:58 UTC
This patch adds a new parameter to action=raw, direction, which can be prev,
next or cur. 

I'm implementing previews of diffs using client-side javascript diffing, and
this will be most useful.
Comment 1 Lupin 2006-02-02 14:35:24 UTC
Created attachment 1342 [details]
proposed patch
Comment 2 Brion Vibber 2006-02-02 17:40:53 UTC
Wouldn't recommend inventing yet another parameter for this.
If it's truly necessary, better to remain consistent with existing parameters.
Comment 3 Lupin 2006-02-02 18:01:27 UTC
Ah, ok. Which existing parameters would you recommend I follow?
Comment 4 Lupin 2006-02-02 18:17:54 UTC
Created attachment 1345 [details]
changed direction to diff

Since this is intended to grab revisions referred to with the diff= parameter
in existing links, I've renamed the direction parameter to diff.

This seems a little illogical to me, but it's an existing parameter.
Comment 5 Lupin 2006-02-04 16:59:11 UTC
Wait, isn't direction already used for this purpose? For example,

http://en.wikipedia.org/w/index.php?title=Wikipedia:Wikipedians&direction=next&oldid=1

I think my original patch makes more sense in view of this.
Comment 6 Rob Church 2006-02-26 16:11:44 UTC
Committed to HEAD more or less intact. :)
Comment 7 Brion Vibber 2006-02-28 08:29:29 UTC
Marking as FIXED since there is no explanation for the reopening.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links