Last modified: 2006-02-03 08:08:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 4833 - SpamBlacklist_body Revision 1.17
SpamBlacklist_body Revision 1.17
Status: RESOLVED WORKSFORME
Product: MediaWiki extensions
Classification: Unclassified
Extensions requests (Other open bugs)
unspecified
All Linux
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://www.myseattle.com/mediawiki/in...
: patch
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-02-02 04:22 UTC by John Walling
Modified: 2006-02-03 08:08 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description John Walling 2006-02-02 04:22:58 UTC
Fatal error: Undefined class name 'revision' in
/home/myseattl/public_html/mediawiki/extensions/SpamBlacklist/SpamBlacklist_body.php
on line 174

Using
    MediaWiki (http://wikipedia.sf.net/): 1.4.4 
    PHP (http://www.php.net/): 4.3.11 (apache) 
    MySQL (http://www.mysql.com/): 4.0.25-standard

I modified line 171
from this:
if ( $dbr->tableExists( 'page' ) ){
to this:
if ( $dbr->tableExists( 'page' ) && class_exists('Revision') ){

Please add a patch to the sourceforge version.
http://cvs.sourceforge.net/viewcvs.py/wikipedia/extensions/SpamBlacklist/SpamBlacklist_body.php?rev=1.17&view=log

= John Walling
http://meta.wikimedia.org/wiki/User:Jwalling
Comment 1 Brion Vibber 2006-02-02 06:34:12 UTC
MediaWiki 1.4 doesn't have a page table, so this shouldn't ever come up.
Comment 2 John Walling 2006-02-02 18:37:43 UTC
It should never come up, and yet it did. Please explain.(In reply to comment #1)
> MediaWiki 1.4 doesn't have a page table, so this shouldn't ever come up.

The patch for forking between schema 1.5 and 1.4 causes a fatal error as it is
designed in the current version. Even though the page table doesn't exist in
1.4, the logic flows up to the point where a fatal error occurs because the
class 'Revision' doesn't exist. How can you say something is not an issue when a
fatal error saying "Hell no! I'm not executing this code"? 
= John Walling
Comment 3 Brion Vibber 2006-02-02 18:45:58 UTC
a) What is "forking between schema 1.5 and 1.4"?

b) The code you quoted above will always evaluate to false if there is
not a 'page' table. If there is not a page table, you're running 1.4 or
earlier and there is no Revision class either. If there is a page table,
either you are running 1.5 or later, and you have a Revision class, or
something is damaged about your installation.

So, is your installation damaged or is there something else wrong?
Comment 4 John Walling 2006-02-02 18:56:32 UTC
(In reply to comment #3)
> a) What is "forking between schema 1.5 and 1.4"?
> 
> b) The code you quoted above will always evaluate to false if there is
> not a 'page' table. If there is not a page table, you're running 1.4 or
> earlier and there is no Revision class either. If there is a page table,
> either you are running 1.5 or later, and you have a Revision class, or
> something is damaged about your installation.
> 
> So, is your installation damaged or is there something else wrong?
> 

If you say it's damaged it must be damaged. I got the code working with my patch
so nothing else is at issue. Cancel the bug report.
= John Walling






Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links