Last modified: 2006-04-28 17:53:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T6825, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 4825 - Profiling table not defined in tables.sql or updaters
Profiling table not defined in tables.sql or updaters
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Database (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-02-01 14:01 UTC by Hugh Prior
Modified: 2006-04-28 17:53 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Hugh Prior 2006-02-01 14:01:14 UTC
Despite the fact that the profiling table is mentioned in many places, the database which gets created does not have 
a "profiling" table, nor is it defined in the 
"maintanence/tables.sql" file.

One of the following needs to be the case:
a) created automatically by default
b) the definition should be included somewhere so that those who wish to use it can do so
c) IF this functionality is deprecated, then all references to it should be removed from the mediawiki code

Thanks.
Comment 1 Rob Church 2006-02-01 16:08:47 UTC
The profiling table isn't used except in certain debugging conditions.
Comment 2 Hugh Prior 2006-02-01 18:12:38 UTC
I am aware of that.  That does not affect the initial comment.  The frequency of
use of a certain part of the software has no bearing on whether it should work
or not.  It may of course affect the priority assigned to fixing it.

As a user of the mediawiki software I have tried in vain to find the definition
of this profiling table.  If I switch profiling to the database on then the code
crashes because the table is not defined.  I do not have any way of defining it
because the definition is nowhere included.  

Either the broken functionality should be removed or it should be made so that
it is usable.
Comment 3 Rob Church 2006-02-01 18:13:46 UTC
Fair enough. I'll look into making sure there is at least a .SQL file there,
with perhaps a script to be run to do the updates.
Comment 4 Hugh Prior 2006-02-01 19:14:55 UTC
:-)
Comment 5 Antoine "hashar" Musso (WMF) 2006-04-28 17:53:10 UTC
Have a look at:
  maintenance/archives/patch-profiling.sql

It's there since june 2004 but you have to add it manually. I added
a comment about that in DefaultSettings.php in trunk@13902 and
REL1_6@13903 .

Should be enough :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links