Last modified: 2014-05-29 18:57:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T2482, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 482 - when TOC is hidden, it should not print


Summary:	when TOC is hidden, it should not print

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Parser (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal minor (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Duplicates:	16869 (view as bug list)
Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2004-09-14 10:22 UTC by Hemanshu Desai
Modified:	2014-05-29 18:57 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Patch to fix this bug (1.28 KB, patch) 2004-11-23 12:40 UTC, Shane King	Details
Add an attachment (proposed patch, testcase, etc.)

Description Hemanshu Desai 2004-09-14 10:22:37 UTC

when the TOC is hidden, it should not print. what happens now is a box with
"Contents" in it gets printed.

Comment 1 Antoine "hashar" Musso (WMF) 2004-09-22 01:28:00 UTC

Hidding is made through javascript so it probably can't be fixed :(

Comment 2 Brion Vibber 2004-09-22 07:20:49 UTC

This should be possible with some style tweaking if we set the outer box's class to something which is 
hidden in the print stylesheet but displays on screen.

(The remaining box shows on screen so you can click the 'show' button, but of course that's unnecessary in 
print.)

Comment 3 Shane King 2004-11-23 12:40:37 UTC

Created attachment 132 [details]
Patch to fix this bug

This patch should be all that's needed to fix this bug. As suggested, it sets
the toc box's class to something that will be hidden in the print stylesheet.

Comment 4 Brion Vibber 2004-11-23 12:59:19 UTC

Thanks, Shane! Patch works correctly in Safari 1.2.4; gone ahead and checked it into 1.4.

Comment 5 Shane King 2004-11-23 13:27:52 UTC

Ah, thanks for testing in another browser, I should note that I tested with IE 6
and Firefox 1.0 on Windows XP.

Comment 6 Fomafix 2009-09-07 10:48:19 UTC

The JavaScript part for tochidden ist lost in r1=6350&r2=7073">http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/skins/common/wikibits.js?r1=6350&r2=7073

Please integrate r1=5091&r2=6350">http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/skins/common/wikibits.js?r1=5091&r2=6350 again.

Comment 7 Church of emacs 2009-09-12 13:46:21 UTC

Done in r56230.

Comment 8 Robin Krahl 2009-10-02 11:16:22 UTC

*** Bug 16869 has been marked as a duplicate of this bug. ***

Comment 9 Fomafix 2014-05-27 20:46:04 UTC

Reopened.

The toc gets not hidden in print when collapsed again.

Comment 10 Gerrit Notification Bot 2014-05-27 20:49:17 UTC

Change 135692 had a related patch set uploaded by Gerrit Patch Uploader:
Hide toc caption on print when collapsed

https://gerrit.wikimedia.org/r/135692

Comment 11 Gerrit Notification Bot 2014-05-29 18:57:46 UTC

Change 135692 merged by jenkins-bot:
Hide toc caption on print when collapsed

https://gerrit.wikimedia.org/r/135692

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links